Re: [132/152] drm/i915/bios: Reverse order of 100/120 Mhz SSC clocks

Greg KH
2011-01-07T21:34:19Z

On Fri, Jan 07, 2011 at 09:18:40PM +0100, François Valenduc wrote:
> Le 06/01/11 01:23, Greg KH a écrit :
> > 2.6.36-stable review patch. If anyone has any objections, please let us know.
> >
> > ------------------
> >
> > From: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > commit 448f53a1ede54eb854d036abf54573281412d650 upstream.
> >
> > Fixes the lack of output on the LVDS panel of the Lenovo U160.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=31596
> > Reported-and-tested-by: Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de>
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> >
> > ---
> > drivers/gpu/drm/i915/intel_bios.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- a/drivers/gpu/drm/i915/intel_bios.c
> > +++ b/drivers/gpu/drm/i915/intel_bios.c
> > @@ -276,7 +276,7 @@ parse_general_features(struct drm_i915_p
> > general->ssc_freq ? 66 : 48;
> > else if (IS_IRONLAKE(dev_priv->dev) || IS_GEN6(dev))
> > dev_priv->lvds_ssc_freq =
> > - general->ssc_freq ? 100 : 120;
> > + general->ssc_freq ? 120 : 100;
> > else
> > dev_priv->lvds_ssc_freq =
> > general->ssc_freq ? 100 : 96;
> >
> >
>
> This commit gives a black screen on many computers and has been reverted
> between 2.6.37-rc8 and 2.6.37. Why has this been added to this review ?

Because it was marked as a -stable patch.

If it's been reverted (and I now see that it has), I should drop it from
this tree. I'll go do that right now.

Thanks for pointing it out.

greg k-h