From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895Ab1AXVgy (ORCPT ); Mon, 24 Jan 2011 16:36:54 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:35373 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892Ab1AXVgw (ORCPT ); Mon, 24 Jan 2011 16:36:52 -0500 From: "Rafael J. Wysocki" To: Jeff Chua Subject: Re: [PATCH 0/11] ACPI: Fixes and cleanups related to iomaps management Date: Mon, 24 Jan 2011 22:36:08 +0100 User-Agent: KMail/1.13.5 (Linux/2.6.38-rc1+; KDE/4.4.4; x86_64; ; ) Cc: Len Brown , LKML , ACPI Devel Maling List , "Linux-pm mailing list" , Matthew Garrett References: <201101201226.41021.rjw@sisk.pl> <201101232128.03007.rjw@sisk.pl> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201101242236.09171.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, January 24, 2011, Jeff Chua wrote: > On Mon, Jan 24, 2011 at 4:28 AM, Rafael J. Wysocki wrote: > > On Sunday, January 23, 2011, Jeff Chua wrote: > >> On Sun, Jan 23, 2011 at 3:12 AM, Rafael J. Wysocki wrote: > >> > On Saturday, January 22, 2011, Jeff Chua wrote: > >> >> 2011/1/22 Rafael J. Wysocki : > >> >> > On Saturday, January 22, 2011, Jeff Chua wrote: > >> Strange. If I didn't offline, it hanged during suspend even without > >> thinkpad_acpi. I could see that the suspend code does the offline > >> automatically, but executing the offline before calling suspend makes > >> it no hanging. > > > > That means there's a problem in the CPU hotplug code that manifests itslef > > during suspend. Is this 100% reproducible? Did it happen with 2.6.37? > > Quite reproducible. Once "something" trigger the hang, no matter how > I reset the system, it'll still hang at suspend. And at other times, > it just worked. I tried many things, but it seems if I go back to use > an earlier version (2.6.37 works perfectly for suspend-to-disk/mem), > then switched back to the newer broken version, it'll work for a few > cycles before hanging at suspend-to-disk. > > I guess it could be CPU hotplug, and may be that thinkpad-acpi is > triggering the broken cpu hotplug to fail. So please try with this commit on top: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=ec30f343d61391ab23705e50a525da1d55395780 Thanks, Rafael