Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

Dmitry Torokhov
2011-01-26T16:51:45Z

On Wed, Jan 26, 2011 at 12:18:29PM -0200, Mauro Carvalho Chehab wrote:
> diff --git a/input.c b/input.c
> index d57a31e..a9bd5e8 100644
> --- a/input.c
> +++ b/input.c
> @@ -101,8 +101,8 @@ int device_open(int nr, int verbose)
> close(fd);
> return -1;
> }
> - if (EV_VERSION != version) {
> - fprintf(stderr, "protocol version mismatch (expected %d, got %d)\n",
> + if (EV_VERSION > version) {
> + fprintf(stderr, "protocol version mismatch (expected >= %d, got %d)\n",
> EV_VERSION, version);

Please do not do this. It causes check to "float" depending on the
version of kernel headers it was compiled against.

The check should be against concrete version (0x10000 in this case).

Thanks.

--
Dmitry