From: Paul Mundt <lethal@linux-sh.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Julia Lawall <julia@diku.dk>,
kernel-janitors@vger.kernel.org,
Michael Hennerich <michael.hennerich@analog.com>,
Bryan Wu <cooloney@kernel.org>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] drivers/video/bf537-lq035.c: Add missing IS_ERR test
Date: Tue, 25 Jan 2011 15:12:03 +0900 [thread overview]
Message-ID: <20110125061203.GD11673@linux-sh.org> (raw)
In-Reply-To: <201101241543.19543.vapier@gentoo.org>
On Mon, Jan 24, 2011 at 03:43:17PM -0500, Mike Frysinger wrote:
> On Monday, January 24, 2011 14:55:21 Julia Lawall wrote:
> > lcd_device_register may return ERR_PTR, so a check is added for this value
> > before the dereference. All of the other changes reorganize the error
> > handling code in this function to avoid duplicating all of it in the added
> > case.
> >
> > In the original code, in one case, the global variable fb_buffer was set to
> > NULL in error code that appears after this variable is initialized. This
> > is done now in all error handling code that has this property.
>
> Acked-by: Mike Frysinger <vapier@gentoo.org>
Applied, thanks.
next prev parent reply other threads:[~2011-01-25 6:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 19:55 [PATCH 0/4] Add missing IS_ERR test Julia Lawall
2011-01-24 19:55 ` [PATCH 1/4] fs/btrfs/inode.c: " Julia Lawall
2011-01-24 19:55 ` [PATCH 2/4] arch/arm/mach-at91/clock.c: " Julia Lawall
2011-01-24 19:56 ` Ryan Mallon
2011-01-24 20:00 ` Julia Lawall
2011-01-24 20:05 ` Vasiliy Kulikov
2011-01-24 20:09 ` Julia Lawall
2011-01-24 20:14 ` Vasiliy Kulikov
2011-01-25 10:33 ` walter harms
2011-01-25 10:43 ` Russell King - ARM Linux
2011-01-25 11:12 ` walter harms
2011-01-25 11:17 ` Russell King - ARM Linux
2011-01-25 11:18 ` Julia Lawall
2011-01-25 11:26 ` Russell King - ARM Linux
2011-01-25 11:31 ` Julia Lawall
2011-01-24 20:11 ` Ryan Mallon
2011-01-24 20:28 ` Julia Lawall
2011-01-24 20:38 ` Ryan Mallon
2011-01-24 21:01 ` Julia Lawall
2011-01-24 21:06 ` Ryan Mallon
2011-01-24 21:31 ` Julia Lawall
2011-01-24 21:51 ` Ryan Mallon
2011-01-24 23:23 ` Russell King - ARM Linux
2011-01-25 1:44 ` Jean-Christophe PLAGNIOL-VILLARD
2011-01-25 6:12 ` Julia Lawall
2011-01-25 17:23 ` Jean-Christophe PLAGNIOL-VILLARD
2011-01-24 19:55 ` [PATCH 3/4] drivers/video/bf537-lq035.c: " Julia Lawall
2011-01-24 20:43 ` Mike Frysinger
2011-01-25 6:12 ` Paul Mundt [this message]
2011-01-25 8:36 ` Hennerich, Michael
2011-01-24 19:55 ` [PATCH 4/4] arch/arm/mach-omap2/smartreflex.c: " Julia Lawall
2011-01-24 21:24 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110125061203.GD11673@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=cooloney@kernel.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox