From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752730Ab1AZDUY (ORCPT ); Tue, 25 Jan 2011 22:20:24 -0500 Received: from cantor.suse.de ([195.135.220.2]:34716 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752344Ab1AZDUX (ORCPT ); Tue, 25 Jan 2011 22:20:23 -0500 Date: Wed, 26 Jan 2011 11:17:34 +0800 From: Greg KH To: Grant Likely Cc: devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] driver-core: remove conditionals around devicetree pointers Message-ID: <20110126031734.GA1636@suse.de> References: <20110126015414.31133.56437.stgit@localhost6.localdomain6> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110126015414.31133.56437.stgit@localhost6.localdomain6> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 25, 2011 at 07:02:02PM -0700, Grant Likely wrote: > Having conditional around the of_match_table and the of_node pointers > turns out to make driver code use ugly #ifdef blocks. Drop the > conditionals and remove the #ifdef blocks from the affected drivers. > > Also tidy up minor whitespace issues within the same hunks. > > Signed-off-by: Grant Likely > --- > > I've held off doing this since I didn't want to needlessly increase > the size of struct device and struct device_driver for users who don't > use CONFIG_OF. However, its quibbling about a tiny amount of memory, > and #ifdef'ing it out this way is ugly for driver code. > > Alternately, if I should be concerned about the extra memory, I could > define some macros/inlines similar to how CONFIG_NUMA is handled. No objection from me, I was wondering when you would get around to doing this :) If you want me to take this in my tree, I'd be glad to, otherwise feel free to send it through yours, and add a: Acked-by: Greg Kroah-Hartman to it. Nice job, greg k-h