From: Ingo Molnar <mingo@elte.hu>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Arjan van de Ven <arjan@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>, Len Brown <len.brown@intel.com>,
Pavel Machek <pavel@ucw.cz>, "Rafael J. Wysocki" <rjw@sisk.pl>,
Frederic Weisbecker <fweisbec@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>, Yinghai Lu <yinghai@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] power_trace: move power_trace to kernel/power/
Date: Wed, 26 Jan 2011 12:03:59 +0100 [thread overview]
Message-ID: <20110126110359.GC27809@elte.hu> (raw)
In-Reply-To: <4D3FE72B.2010701@cn.fujitsu.com>
* Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
>
> I think kernel/trace/ is the place for the tracing implementation files,
> it is not a good place for tracepoint creation. Any subsystem should
> creates tracepoints at its owner location, see also all other CREATE_TRACE_POINTS.
> For example: net-traces.c is in the net/core/ directory.
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 353d3fe..25c3767 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -55,6 +55,7 @@ obj-$(CONFIG_MODULES) += module.o
> obj-$(CONFIG_KALLSYMS) += kallsyms.o
> obj-$(CONFIG_PM) += power/
> obj-$(CONFIG_FREEZER) += power/
> +obj-$(CONFIG_TRACEPOINTS) += power/
> obj-$(CONFIG_BSD_PROCESS_ACCT) += acct.o
> obj-$(CONFIG_KEXEC) += kexec.o
> obj-$(CONFIG_BACKTRACE_SELF_TEST) += backtracetest.o
> @@ -100,7 +101,6 @@ obj-$(CONFIG_FUNCTION_TRACER) += trace/
> obj-$(CONFIG_TRACING) += trace/
> obj-$(CONFIG_X86_DS) += trace/
> obj-$(CONFIG_RING_BUFFER) += trace/
> -obj-$(CONFIG_TRACEPOINTS) += trace/
> obj-$(CONFIG_SMP) += sched_cpupri.o
> obj-$(CONFIG_IRQ_WORK) += irq_work.o
> obj-$(CONFIG_PERF_EVENTS) += perf_event.o
> diff --git a/kernel/power/Makefile b/kernel/power/Makefile
> index c350e18..b5a74f5 100644
> --- a/kernel/power/Makefile
> +++ b/kernel/power/Makefile
> @@ -9,3 +9,4 @@ obj-$(CONFIG_HIBERNATION) += hibernate.o snapshot.o swap.o user.o \
> block_io.o
>
> obj-$(CONFIG_MAGIC_SYSRQ) += poweroff.o
> +obj-$(CONFIG_TRACEPOINTS) += power-traces.o
What is 'power-traces'? Please name it power-events.c/power-events.o.
Thanks,
Ingo
prev parent reply other threads:[~2011-01-26 11:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 9:19 [RFC PATCH] power_trace: move power_trace to kernel/power/ Lai Jiangshan
2011-01-26 11:03 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126110359.GC27809@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=laijs@cn.fujitsu.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox