From: Andrew Morton <akpm@linux-foundation.org>
To: Kees Cook <kees.cook@canonical.com>
Cc: linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>, Tejun Heo <tj@kernel.org>,
Marcus Meissner <meissner@suse.de>,
Jason Wessel <jason.wessel@windriver.com>,
Eugene Teo <eugeneteo@kernel.org>, Joe Perches <joe@perches.com>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
Len Brown <len.brown@intel.com>, Changli Gao <xiaosuo@gmail.com>,
Dan Rosenberg <drosenberg@vsecurity.com>
Subject: Re: [PATCH] use %pK for /proc/kallsyms and /proc/modules
Date: Wed, 26 Jan 2011 15:57:06 -0800 [thread overview]
Message-ID: <20110126155706.0188fe02.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110125181058.GA25670@outflux.net>
On Tue, 25 Jan 2011 10:10:58 -0800
Kees Cook <kees.cook@canonical.com> wrote:
> Instead of messing with permissions on these files,
This implies that the patch alters permission handling, only it
doesn't. But I worked it out!
> use %pK for kernel
> addresses to reduce potential information leaks that might be used to
> help target kernel privilege escalation exploits.
>
> Note that this changes %x to %p, so some legitimately 0 values in
> /proc/kallsyms would have changed from 00000000 to "(null)". To avoid
> this, "(null)" is not used when using the "K" format. Anything parsing
> such addresses should have no problem with this change. (Thanks to Joe
> Perches for the suggestion.)
>
> Note that when compiling with -Wformat, these harmless warnings will
> be emitted, and can be ignored:
> warning: '0' flag used with ___%p___ gnu_printf format
OK, so what applications did this patch just break?
next prev parent reply other threads:[~2011-01-26 23:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 18:10 [PATCH] use %pK for /proc/kallsyms and /proc/modules Kees Cook
2011-01-26 23:57 ` Andrew Morton [this message]
2011-01-27 0:29 ` Kees Cook
2011-01-27 0:46 ` Andrew Morton
2011-01-27 1:30 ` Kees Cook
2011-01-27 0:15 ` Joe Perches
2011-01-27 0:28 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126155706.0188fe02.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=drosenberg@vsecurity.com \
--cc=eugeneteo@kernel.org \
--cc=jason.wessel@windriver.com \
--cc=joe@perches.com \
--cc=kees.cook@canonical.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=meissner@suse.de \
--cc=rusty@rustcorp.com.au \
--cc=tj@kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox