From: Robert Jennings <rcj@linux.vnet.ibm.com>
To: Nitin Gupta <ngupta@vflare.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Pekka Enberg <penberg@cs.helsinki.fi>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/7] zram: Prevent overflow in logical block size
Date: Wed, 26 Jan 2011 11:23:18 -0600 [thread overview]
Message-ID: <20110126172317.GD8446@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110126172148.GB8446@linux.vnet.ibm.com>
On a 64K page kernel, the value PAGE_SIZE passed to
blk_queue_logical_block_size would overflow the logical block size
argument (resulting in setting it to 0).
Take the minimum of PAGE_SIZE or 4096 and use this for the block device
logical block size.
Signed-off-by: Robert Jennings <rcj@linux.vnet.ibm.com>
---
drivers/staging/zram/zram_drv.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
index d0e9e02..d5e0275 100644
--- a/drivers/staging/zram/zram_drv.c
+++ b/drivers/staging/zram/zram_drv.c
@@ -621,7 +621,8 @@ static int create_device(struct zram *zram, int device_id)
* and n*PAGE_SIZED sized I/O requests.
*/
blk_queue_physical_block_size(zram->disk->queue, PAGE_SIZE);
- blk_queue_logical_block_size(zram->disk->queue, PAGE_SIZE);
+ blk_queue_logical_block_size(zram->disk->queue,
+ (unsigned short) min_t(unsigned int, PAGE_SIZE, 4096));
blk_queue_io_min(zram->disk->queue, PAGE_SIZE);
blk_queue_io_opt(zram->disk->queue, PAGE_SIZE);
--
1.6.0.2
next prev parent reply other threads:[~2011-01-26 17:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 17:21 [PATCH 0/7] zram/xvmalloc: 64K page fixes and optimizations Robert Jennings
2011-01-26 17:22 ` [PATCH 1/7] zram/vmalloc: Correct tunings to enable use with 64K pages Robert Jennings
2011-01-26 17:48 ` Pekka Enberg
2011-01-26 18:50 ` Robert Jennings
2011-01-26 17:23 ` Robert Jennings [this message]
2011-01-26 17:42 ` [PATCH 2/7] zram: Prevent overflow in logical block size Pekka Enberg
2011-01-26 19:09 ` Robert Jennings
2011-01-26 19:14 ` Pekka Enberg
2011-01-26 17:23 ` [PATCH 3/7] zram: Speed insertion of new pages with cached idx Robert Jennings
2011-01-26 17:53 ` Pekka Enberg
2011-01-26 19:50 ` Robert Jennings
2011-01-26 17:25 ` [PATCH 4/7] zram/xvmalloc: free bit block insertion optimization Robert Jennings
2011-01-26 17:55 ` Pekka Enberg
2011-01-26 18:40 ` Robert Jennings
2011-01-26 18:51 ` Pekka Enberg
2011-01-26 18:44 ` Nitin Gupta
2011-01-26 17:26 ` [PATCH 5/7] zram/xvmalloc: wrap debug code in #ifdef DEBUG Robert Jennings
2011-01-26 17:44 ` Pekka Enberg
2011-01-26 18:27 ` Robert Jennings
2011-01-26 17:27 ` [PATCH 6/7] zram/xvmalloc: Close 32byte hole on 64-bit CPUs Robert Jennings
2011-01-26 17:43 ` Pekka Enberg
2011-01-26 17:27 ` [PATCH 7/7] zram: mark the disk as non-rotating media Robert Jennings
2011-01-26 17:44 ` Pekka Enberg
2011-01-26 17:48 ` Dan Carpenter
2011-01-26 17:52 ` Robert Jennings
2011-01-26 18:26 ` Robert Jennings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126172317.GD8446@linux.vnet.ibm.com \
--to=rcj@linux.vnet.ibm.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox