From: Andrew Morton <akpm@linux-foundation.org>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Daniel Lezcano <daniel.lezcano@free.fr>,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cgroup : remove the ns_cgroup
Date: Wed, 26 Jan 2011 17:45:13 -0800 [thread overview]
Message-ID: <20110126174513.c2a20fff.akpm@linux-foundation.org> (raw)
In-Reply-To: <4D40C5A3.4070703@cn.fujitsu.com>
On Thu, 27 Jan 2011 09:08:51 +0800 Li Zefan <lizf@cn.fujitsu.com> wrote:
> Andrew Morton wrote:
> > On Tue, 25 Jan 2011 10:39:48 +0100
> > Daniel Lezcano <daniel.lezcano@free.fr> wrote:
> >
> >> This patch removes the ns_cgroup as suggested in the following thread:
> >
> > I had this patch queued up in September last year, but dropped it. Why
> > did I do that?
>
> Because you wanted to wait for some time for users (if any) to notice this
> coming change.
>
> Author: Daniel Lezcano <daniel.lezcano@free.fr>
> Date: Wed Oct 27 15:33:38 2010 -0700
>
> cgroup: notify ns_cgroup deprecated
>
> The ns_cgroup will be removed very soon. Let's warn, for this version,
> ns_cgroup is deprecated.
>
> Make ns_cgroup and clone_children exclusive. If the clone_children is set
> and the ns_cgroup is mounted, let's fail with EINVAL when the ns_cgroup
> subsys is created (a printk will help the user to understand why the
> creation fails).
>
> Update the feature remove schedule file with the deprecated ns_cgroup.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@free.fr>
> Acked-by: Paul Menage <menage@google.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
ooh, that was clever of me.
Here is the text which was missing from the changelog:
This is a userspace-visible change. Commit 45531757b45c ("cgroup:
notify ns_cgroup deprecated") (merged into 2.6.27) caused the kernel
to emit a printk warning users that the feature is planned for
removal. Since that time we have heard from XXX users who were
affected by this.
Please provide XXX.
How do we know that 2.6.37->2.6.38 is long enough? Will any major
distros be released containing this warning in that timeframe? I doubt
it.
next prev parent reply other threads:[~2011-01-27 1:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 9:39 [PATCH] cgroup : remove the ns_cgroup Daniel Lezcano
2011-01-27 0:16 ` Andrew Morton
2011-01-27 0:18 ` Andrew Morton
2011-01-27 1:08 ` Li Zefan
2011-01-27 1:45 ` Andrew Morton [this message]
2011-01-27 8:50 ` Daniel Lezcano
2011-01-28 15:45 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126174513.c2a20fff.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=daniel.lezcano@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox