From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753893Ab1AZS0j (ORCPT ); Wed, 26 Jan 2011 13:26:39 -0500 Received: from e39.co.us.ibm.com ([32.97.110.160]:55675 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752424Ab1AZS0h (ORCPT ); Wed, 26 Jan 2011 13:26:37 -0500 Date: Wed, 26 Jan 2011 12:26:29 -0600 From: Robert Jennings To: Dan Carpenter , Nitin Gupta , Greg Kroah-Hartman , Pekka Enberg , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] zram: mark the disk as non-rotating media Message-ID: <20110126182629.GA17383@linux.vnet.ibm.com> Mail-Followup-To: Dan Carpenter , Nitin Gupta , Greg Kroah-Hartman , Pekka Enberg , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20110126172743.GI8446@linux.vnet.ibm.com> <20110126175258.GJ8446@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110126175258.GJ8446@linux.vnet.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Robert Jennings (rcj@linux.vnet.ibm.com) wrote: > * Dan Carpenter (error27@gmail.com) wrote: > > On Wed, Jan 26, 2011 at 11:27:44AM -0600, Robert Jennings wrote: > > > Adding QUEUE_FLAG_NONROT for the in the request_queue flags. When used > > ^^^^^^^^^^^^^^ > > "to the" perhaps? > > Yeah, that was edited a few times and never re-read. Thanks. > > > > as a swap device, scan_swap_map will avoid the extra work of optimizing > > > for rotating media. > > > > > > Signed-off-by: Robert Jennings > > > --- > > > drivers/staging/zram/zram_drv.c | 1 + > > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > > > diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c > > > index d5e0275..450c618 100644 > > > --- a/drivers/staging/zram/zram_drv.c > > > +++ b/drivers/staging/zram/zram_drv.c > > > @@ -593,6 +593,7 @@ static int create_device(struct zram *zram, int device_id) > > > goto out; > > > } > > > > > > + zram->queue->queue_flags ^= QUEUE_FLAG_NONROT; > > > > QUEUE_FLAG_NONROT is 14. We want to set the 14 bit. This won't work. > > > > Use queue_flag_set_unlocked(QUEUE_FLAG_NONROT, zram->queue); I need to drop this patch entirely. QUEUE_FLAG_NONROT is set in zram_init_device and is unnecessary here.