From: Andrew Morton <akpm@linux-foundation.org>
To: Olaf Hering <olaf@aepfle.de>
Cc: Vivek Goyal <vgoyal@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crash_dump: export is_kdump_kernel to modules, consolidate elfcorehdr_addr, setup_elfcorehdr and saved_max_pfn
Date: Thu, 27 Jan 2011 14:49:39 -0800 [thread overview]
Message-ID: <20110127144939.41b3ac39.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110127105751.GB31360@aepfle.de>
On Thu, 27 Jan 2011 11:57:51 +0100
Olaf Hering <olaf@aepfle.de> wrote:
> > Apart from that, moving the code from arch specific section to generic
> > code helps. So that bit you can retain and get rid of export of
> > is_kdump_kernel() and elfcorehdr_addr.
>
>
> Andrew, do you want a new patch with the export of elfcorehdr_addr
> removed, or can you edit my patch and remove that one line?
This?
--- a/kernel/crash_dump.c~crash_dump-export-is_kdump_kernel-to-modules-consolidate-elfcorehdr_addr-setup_elfcorehdr-and-saved_max_pfn-fix-fix
+++ a/kernel/crash_dump.c
@@ -18,7 +18,6 @@ unsigned long saved_max_pfn;
* it under CONFIG_CRASH_DUMP and not CONFIG_PROC_VMCORE.
*/
unsigned long long elfcorehdr_addr = ELFCORE_ADDR_MAX;
-EXPORT_SYMBOL_GPL(elfcorehdr_addr);
/*
* elfcorehdr= specifies the location of elf core header stored by the crashed
_
prev parent reply other threads:[~2011-01-27 22:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 16:10 [PATCH] crash_dump: export is_kdump_kernel to modules, consolidate elfcorehdr_addr, setup_elfcorehdr and saved_max_pfn Olaf Hering
2011-01-26 5:24 ` WANG Cong
2011-01-27 0:04 ` Andrew Morton
2011-01-27 10:47 ` Olaf Hering
2011-01-27 22:49 ` Andrew Morton
2011-01-27 2:43 ` Vivek Goyal
2011-01-27 10:57 ` Olaf Hering
2011-01-27 22:49 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110127144939.41b3ac39.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).