From: "Michael S. Tsirkin" <mst@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Rusty Russell <rusty@rustcorp.com.au>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio_blk: allow re-reading config space at runtime
Date: Thu, 27 Jan 2011 17:29:26 +0200 [thread overview]
Message-ID: <20110127152926.GA4898@redhat.com> (raw)
In-Reply-To: <20110118235401.GA16219@lst.de>
On Wed, Jan 19, 2011 at 12:54:01AM +0100, Christoph Hellwig wrote:
> On Wed, Jan 19, 2011 at 09:56:09AM +1030, Rusty Russell wrote:
> > > I don't think we have much choice. We're getting called from irq
> > > context, so we'll need to allocate memory to offload things. That's
> > > unless we keep a thread around that we just need to wake up, which
> > > would be a huge waste of ressources.
> >
> > Yes, but can we keep a workqueue struct around?
>
> We can keep one around, but we can't prevent the virtio core code from
> calling us again while it's still in use.
Yes but in that specific situation (double schedule before
it runs once) discarding one change notification
would not hurt at all.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2011-01-27 15:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 16:01 [PATCH] virtio_blk: allow re-reading config space at runtime Christoph Hellwig
2011-01-18 1:08 ` Rusty Russell
2011-01-18 12:27 ` Christoph Hellwig
2011-01-18 23:26 ` Rusty Russell
2011-01-18 23:54 ` Christoph Hellwig
2011-01-27 15:29 ` Michael S. Tsirkin [this message]
2011-02-01 17:32 ` Christoph Hellwig
2011-02-01 18:38 ` Michael S. Tsirkin
2011-02-01 19:21 ` Christoph Hellwig
2011-02-01 19:51 ` Michael S. Tsirkin
2011-02-01 20:43 ` [PATCH v3] " Christoph Hellwig
2011-02-04 2:39 ` Rusty Russell
2011-01-27 15:32 ` [PATCH] " Michael S. Tsirkin
2011-02-01 17:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110127152926.GA4898@redhat.com \
--to=mst@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox