From: Amit Shah <amit.shah@redhat.com>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH 1/3] tty: move hvc drivers to drivers/tty/hvc/
Date: Thu, 27 Jan 2011 23:59:44 +0530 [thread overview]
Message-ID: <20110127182916.GA4688@amit-x200.redhat.com> (raw)
In-Reply-To: <1295546625-30681-1-git-send-email-gregkh@suse.de>
On (Thu) Jan 20 2011 [10:03:43], Greg Kroah-Hartman wrote:
> As requested by Arnd Bergmann, the hvc drivers are now
> moved to the drivers/tty/hvc/ directory. The virtio_console.c driver
> was also moved, as it required the hvc_console.h file to be able to be
> built, and it really is a hvc driver.
I just saw this now as a result of this patch entering mainline. I
would have liked to be CC'ed to the patches. Also, I don't like the
move of the virtio_console.c file to drivers/tty/hvc. virtio_console.c
is not only an hvc driver; one of its functions is to hook some ports to
hvc, but it's mostly a generic driver these days.
(I also note the MAINTAINERS entry was ignored and not updated in the
3rd patch of this series.)
Can you please move it back?
I could perhaps think of a way of splitting the file so the hvc bits can
be moved to drivers/tty/hvc/ and having the core stay in drivers/char/,
but that'll have to wait for the next cycle.
Amit
next prev parent reply other threads:[~2011-01-27 18:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 17:49 [GIT PATCH] TTY/serial driver movement for .38 Greg KH
2011-01-20 18:03 ` [PATCH 1/3] tty: move hvc drivers to drivers/tty/hvc/ Greg Kroah-Hartman
2011-01-20 18:27 ` Arnd Bergmann
2011-01-27 18:29 ` Amit Shah [this message]
2011-01-27 21:53 ` Arnd Bergmann
2011-01-28 2:57 ` Amit Shah
2011-01-28 4:21 ` Greg KH
2011-01-28 5:59 ` Amit Shah
2011-01-28 15:20 ` Greg KH
2011-01-31 22:14 ` Greg KH
2011-02-01 3:27 ` Amit Shah
2011-02-01 4:01 ` [PATCH] virtio: console: Move file back to drivers/char/ Amit Shah
2011-02-01 12:40 ` Arnd Bergmann
2011-01-20 18:03 ` [PATCH 2/3] tty: move drivers/serial/ to drivers/tty/serial/ Greg Kroah-Hartman
2011-01-20 18:27 ` Arnd Bergmann
2011-01-20 18:03 ` [PATCH 3/3] tty: update MAINTAINERS file due to driver movement Greg Kroah-Hartman
2011-01-20 18:32 ` [GIT PATCH] TTY/serial driver movement for .38 Arnd Bergmann
2011-01-20 18:48 ` Greg KH
2011-01-20 19:45 ` Alan Cox
2011-01-20 20:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110127182916.GA4688@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=arnd@arndb.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).