From: Andrea Arcangeli <aarcange@redhat.com>
To: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Cc: "Andi Kleen" <andi@firstfloor.org>,
AKPM <akpm@linux-foundation.org>,
"Huang Ying" <ying.huang@intel.com>,
"Hidetoshi Seto" <seto.hidetoshi@jp.fujitsu.com>,
LKLM <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -v2 1/3] Fix splitting poisoned THP.
Date: Fri, 28 Jan 2011 17:16:57 +0100 [thread overview]
Message-ID: <20110128161657.GG16981@random.random> (raw)
In-Reply-To: <4D4259B0.6040902@np.css.fujitsu.com>
Hello Jin,
On Fri, Jan 28, 2011 at 02:52:48PM +0900, Jin Dongming wrote:
> + /*
> + * FIXME: if splitting THP is failed, it is better
> + * to stop the following operation rather than
> + * causing panic by unmapping. System might survive
> + * if the page is freed later.
> + */
I don't think there would be panic by unmapping. But the page has
already been freed so there's no need to kill anything.
A part from this comment which I'm uncertain about the panic, this new
series looks good to me!
Thanks,
Andrea
prev parent reply other threads:[~2011-01-28 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 5:52 [PATCH -v2 1/3] Fix splitting poisoned THP Jin Dongming
2011-01-28 16:16 ` Andrea Arcangeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110128161657.GG16981@random.random \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=jin.dongming@np.css.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox