Re: [PATCH 1/4] kmap_atomic: remove the second parameter

[Marcin Slusarz <marcin.slusarz@gmail.com>]

On Sun, Jan 30, 2011 at 05:46:57PM +0800, Amerigo Wang wrote:
> Now the second parameter of kmap_atomic() are totally unused,
> this patch removes it from all callers.
> 
> Most of this patch is generated by the following commands:
> 
> find . -name '*.[c|h]' -exec sed -i -e 's#\bkmap_atomic(\(.*\),.*)#kmap_atomic(\1)#' '{}' \;
> find . -name '*.[c|h]' -exec sed -i -e 's#\bkunmap_atomic(\(.*\),.*)#kunmap_atomic(\1)#' '{}' \;
> 
> However, there are some exceptions:
> 
> 1) When the second parameter of kmap_atomic() is a variable
> 2) When the second parameter of kmap_atomic() is not in the same line
> 
> For 1), they are mostly in btrfs and crypto code, have to fix
> one by one;
> For 2), I fixed them by hands too.
> 
> This patch passes 'make allyesconfig' test on both i386 and x86_64.
> 
> Signed-off-by: WANG Cong <amwang@redhat.com>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> 
> ---
>
> (...)
>
> diff --git a/sound/oss/Makefile b/sound/oss/Makefile
> index 96f14dc..90ffb99 100644
> --- a/sound/oss/Makefile
> +++ b/sound/oss/Makefile
> @@ -87,7 +87,7 @@ ifeq ($(CONFIG_PSS_HAVE_BOOT),y)
>  	$(obj)/bin2hex pss_synth < $< > $@
>  else
>      $(obj)/pss_boot.h:
> -	(							\
> +	$(Q)(							\
>  	    echo 'static unsigned char * pss_synth = NULL;';	\
>  	    echo 'static int pss_synthLen = 0;';		\
>  	) > $@
> @@ -102,7 +102,7 @@ ifeq ($(CONFIG_TRIX_HAVE_BOOT),y)
>  	$(obj)/hex2hex -i trix_boot < $< > $@
>  else
>      $(obj)/trix_boot.h:
> -	(							\
> +	$(Q)(							\
>  	    echo 'static unsigned char * trix_boot = NULL;';	\
>  	    echo 'static int trix_boot_len = 0;';		\
>  	) > $@
> -- 

does it belong here?

Marcin