From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753174Ab1A3Kfp (ORCPT <rfc822;w@1wt.eu>);
	Sun, 30 Jan 2011 05:35:45 -0500
Received: from mail-ww0-f44.google.com ([74.125.82.44]:57956 "EHLO
	mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752400Ab1A3Kfo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 30 Jan 2011 05:35:44 -0500
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=UOaQK/4PlX0FqPTk7Rm/n7hzBM4As//4VJppcCjRi5SgJ9Ylb4du7agprni7G4Cwde
         GdL64WDsg1XCxXmedPDCG/URbtIGyQ31a56KbLmJeJHEDEY2jD3MD8b5o7KA/HLHlL9j
         vSNUaeD/xeqK5OyLnVydMAJu/reylfzpat21Y=
Date: Sun, 30 Jan 2011 11:33:48 +0100
From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Herbert Xu <herbert@gondor.hengli.com.au>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/4] kmap_atomic: remove the second parameter
Message-ID: <20110130103348.GA2528@joi.lan>
References: <1296380820-8801-1-git-send-email-amwang@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1296380820-8801-1-git-send-email-amwang@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jan 30, 2011 at 05:46:57PM +0800, Amerigo Wang wrote:
> Now the second parameter of kmap_atomic() are totally unused,
> this patch removes it from all callers.
> 
> Most of this patch is generated by the following commands:
> 
> find . -name '*.[c|h]' -exec sed -i -e 's#\bkmap_atomic(\(.*\),.*)#kmap_atomic(\1)#' '{}' \;
> find . -name '*.[c|h]' -exec sed -i -e 's#\bkunmap_atomic(\(.*\),.*)#kunmap_atomic(\1)#' '{}' \;
> 
> However, there are some exceptions:
> 
> 1) When the second parameter of kmap_atomic() is a variable
> 2) When the second parameter of kmap_atomic() is not in the same line
> 
> For 1), they are mostly in btrfs and crypto code, have to fix
> one by one;
> For 2), I fixed them by hands too.
> 
> This patch passes 'make allyesconfig' test on both i386 and x86_64.
> 
> Signed-off-by: WANG Cong <amwang@redhat.com>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> 
> ---
>
> (...)
>
> diff --git a/sound/oss/Makefile b/sound/oss/Makefile
> index 96f14dc..90ffb99 100644
> --- a/sound/oss/Makefile
> +++ b/sound/oss/Makefile
> @@ -87,7 +87,7 @@ ifeq ($(CONFIG_PSS_HAVE_BOOT),y)
>  	$(obj)/bin2hex pss_synth < $< > $@
>  else
>      $(obj)/pss_boot.h:
> -	(							\
> +	$(Q)(							\
>  	    echo 'static unsigned char * pss_synth = NULL;';	\
>  	    echo 'static int pss_synthLen = 0;';		\
>  	) > $@
> @@ -102,7 +102,7 @@ ifeq ($(CONFIG_TRIX_HAVE_BOOT),y)
>  	$(obj)/hex2hex -i trix_boot < $< > $@
>  else
>      $(obj)/trix_boot.h:
> -	(							\
> +	$(Q)(							\
>  	    echo 'static unsigned char * trix_boot = NULL;';	\
>  	    echo 'static int trix_boot_len = 0;';		\
>  	) > $@
> -- 

does it belong here?

Marcin