From: "Rogério Brito" <rbrito@ime.usp.br>
To: Alexander Holler <holler@ahsoftware.de>
Cc: linux-kernel@vger.kernel.org,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
"Gustavo F. Padovan" <padovan@profusion.mobi>
Subject: Re: [PATCH] ath3k: Avoid duplication of code
Date: Sun, 30 Jan 2011 19:38:32 -0200 [thread overview]
Message-ID: <20110130213832.GA4940@ime.usp.br> (raw)
In-Reply-To: <4D44013B.8050306@ahsoftware.de>
Hi, Alexander.
On Jan 29 2011, Alexander Holler wrote:
> Am 28.01.2011 23:18, schrieb Rogério Brito:
> >Thanks for all the feedback on the previous patches. The one that
> >didn't compile before was sent without a hunk. This time everything
> >all the basics are verified.
>
> They both had the same error, so I assume none of them compiled.
No, they both compiled. It was just that I messed up when generating my
patches (with git add --interactive). My git-fu is currently low, but
improving. :)
Anyway, the new version that I sent (when applied) compiles, and makes it
shorter to read the code (some could say that it more explicitly exposes
what happens in the function).
Regards,
--
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
next prev parent reply other threads:[~2011-01-30 21:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 23:24 [PATCH 02/02] ath3k: Avoid duplication of code Rogério Brito
2011-01-28 8:56 ` Alexander Holler
2011-01-28 22:18 ` [PATCH] " Rogério Brito
2011-01-29 11:59 ` Alexander Holler
2011-01-30 21:38 ` Rogério Brito [this message]
2011-02-02 16:37 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110130213832.GA4940@ime.usp.br \
--to=rbrito@ime.usp.br \
--cc=holler@ahsoftware.de \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox