[GIT PULL] AMD microcode fixes

[GIT PULL] AMD microcode fixes

[Borislav Petkov]

Hey Ingo,

please pull from the branch below to receive a bunch of AMD microcode
driver fixes and cleanups. They are not strictly needed for .38 so
you could easily postpone them for .39 but still have them cook in
linux-next.

Patches survived testing here and were out for review a week ago:
http://marc.info/?l=linux-kernel&m=129588278209579

There's one out-of-tree change to <drivers/base/sys.c> which Greg hasn't
explicitly acked yet but judging by his silence he has nothing against
it :).

Thanks.

The following changes since commit 1bae4ce27c9c90344f23c65ea6966c50ffeae2f5:

  Linux 2.6.38-rc2 (2011-01-21 19:01:34 -0800)

are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git ucode-fixes

Borislav Petkov (7):
      sysdev: Do not register with sysdev when erroring on add
      x86, microcode: Correct sysdev_add error path
      x86, microcode, AMD: Release firmware on error
      x86, microcode, AMD: Simplify install_equiv_cpu_table
      x86, microcode, AMD: Simplify get_next_ucode
      x86, microcode, AMD: Remove unneeded memset call
      x86, microcode, AMD: Cleanup dmesg output

 arch/x86/kernel/microcode_amd.c  |  142 ++++++++++++++++++--------------------
 arch/x86/kernel/microcode_core.c |    6 +-
 drivers/base/sys.c               |   65 ++++++++++++-----
 3 files changed, 118 insertions(+), 95 deletions(-)

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Re: [GIT PULL] AMD microcode fixes

[Ingo Molnar]

* Borislav Petkov <bp@amd64.org> wrote:

> There's one out-of-tree change to <drivers/base/sys.c> which Greg hasn't
> explicitly acked yet but judging by his silence he has nothing against
> it :).

Hm, the drivers/base/sys.c portion is not particularly small:

>  arch/x86/kernel/microcode_amd.c  |  142 ++++++++++++++++++--------------------
>  arch/x86/kernel/microcode_core.c |    6 +-
>  drivers/base/sys.c               |   65 ++++++++++++-----
>  3 files changed, 118 insertions(+), 95 deletions(-)

So i'd really like to have an Acked-by from Greg.

Greg, what's your take on this? The patches are here:

> Patches survived testing here and were out for review a week ago:
> http://marc.info/?l=linux-kernel&m=129588278209579

	Ingo

Re: [GIT PULL] AMD microcode fixes

[Borislav Petkov]

On Thu, Feb 03, 2011 at 05:35:48AM -0500, Ingo Molnar wrote:
> 
> * Borislav Petkov <bp@amd64.org> wrote:
> 
> > There's one out-of-tree change to <drivers/base/sys.c> which Greg hasn't
> > explicitly acked yet but judging by his silence he has nothing against
> > it :).
> 
> Hm, the drivers/base/sys.c portion is not particularly small:
> 
> >  arch/x86/kernel/microcode_amd.c  |  142 ++++++++++++++++++--------------------
> >  arch/x86/kernel/microcode_core.c |    6 +-
> >  drivers/base/sys.c               |   65 ++++++++++++-----
> >  3 files changed, 118 insertions(+), 95 deletions(-)
> 
> So i'd really like to have an Acked-by from Greg.
> 
> Greg, what's your take on this? The patches are here:

Yeah, I've sent him the chunk as two patches already and they're
going to go over his tree. I'll redo the pull request without the
<drivers/base/sys.c> portion maybe today.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Re: [GIT PULL] AMD microcode fixes

[Greg KH]

On Thu, Feb 03, 2011 at 11:35:48AM +0100, Ingo Molnar wrote:
> 
> * Borislav Petkov <bp@amd64.org> wrote:
> 
> > There's one out-of-tree change to <drivers/base/sys.c> which Greg hasn't
> > explicitly acked yet but judging by his silence he has nothing against
> > it :).
> 
> Hm, the drivers/base/sys.c portion is not particularly small:
> 
> >  arch/x86/kernel/microcode_amd.c  |  142 ++++++++++++++++++--------------------
> >  arch/x86/kernel/microcode_core.c |    6 +-
> >  drivers/base/sys.c               |   65 ++++++++++++-----
> >  3 files changed, 118 insertions(+), 95 deletions(-)
> 
> So i'd really like to have an Acked-by from Greg.
> 
> Greg, what's your take on this? The patches are here:

My take was that I NAKed it, Borislav was going to redo this series
without this patch in it as it was not necessary for his microcode
changes.

thanks,

greg k-h