From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH -mmotm] backlight: apple_bl depends on ACPI
Date: Mon, 31 Jan 2011 22:31:03 +0000 [thread overview]
Message-ID: <20110131223103.GA15093@srcf.ucam.org> (raw)
In-Reply-To: <20110126111602.7bfea64e.randy.dunlap@oracle.com>
On Wed, Jan 26, 2011 at 11:16:02AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> apple_bl uses ACPI interfaces (data & code), so it should depend on ACPI.
>
> drivers/video/backlight/apple_bl.c:142: warning: 'struct acpi_device' declared inside parameter list
> drivers/video/backlight/apple_bl.c:142: warning: its scope is only this definition or declaration, which is probably not what you want
> drivers/video/backlight/apple_bl.c:201: warning: 'struct acpi_device' declared inside parameter list
> drivers/video/backlight/apple_bl.c:215: error: variable 'apple_bl_driver' has initializer but incomplete type
> drivers/video/backlight/apple_bl.c:216: error: unknown field 'name' specified in initializer
> drivers/video/backlight/apple_bl.c:216: warning: excess elements in struct initializer
> drivers/video/backlight/apple_bl.c:216: warning: (near initialization for 'apple_bl_driver')
> drivers/video/backlight/apple_bl.c:217: error: unknown field 'ids' specified in initializer
> drivers/video/backlight/apple_bl.c:217: warning: excess elements in struct initializer
> drivers/video/backlight/apple_bl.c:217: warning: (near initialization for 'apple_bl_driver')
> drivers/video/backlight/apple_bl.c:218: error: unknown field 'ops' specified in initializer
> drivers/video/backlight/apple_bl.c:218: error: extra brace group at end of initializer
> drivers/video/backlight/apple_bl.c:218: error: (near initialization for 'apple_bl_driver')
> drivers/video/backlight/apple_bl.c:221: warning: excess elements in struct initializer
> drivers/video/backlight/apple_bl.c:221: warning: (near initialization for 'apple_bl_driver')
> drivers/video/backlight/apple_bl.c:226: error: implicit declaration of function 'acpi_bus_register_driver'
> drivers/video/backlight/apple_bl.c:231: error: implicit declaration of function 'acpi_bus_unregister_driver'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Matthew Garrett <mjg@redhat.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
Acked-by: Matthew Garrett <mjg@redhat.com>
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-01-31 22:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 23:48 mmotm 2011-01-25-15-47 uploaded akpm
2011-01-26 10:20 ` [patch] epoll-fix-compiler-warning-and-optimize-the-non-blocking-path-fix Johannes Weiner
2011-01-26 15:05 ` Davide Libenzi
2011-01-26 19:16 ` [PATCH -mmotm] backlight: apple_bl depends on ACPI Randy Dunlap
2011-01-31 22:31 ` Matthew Garrett [this message]
2011-02-03 7:39 ` epoll broken [was: mmotm 2011-01-25-15-47 uploaded] Jiri Slaby
2011-02-03 7:53 ` Eric Dumazet
2011-02-03 9:03 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110131223103.GA15093@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox