From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756597Ab1AaWci (ORCPT ); Mon, 31 Jan 2011 17:32:38 -0500 Received: from s15228384.onlinehome-server.info ([87.106.30.177]:45392 "EHLO mail.x86-64.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754300Ab1AaWch (ORCPT ); Mon, 31 Jan 2011 17:32:37 -0500 Date: Mon, 31 Jan 2011 23:33:19 +0100 From: Borislav Petkov To: Greg KH , Ingo Molnar Cc: "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman Subject: Re: [PATCH 1/7] sysdev: Do not register with sysdev when erroring on add Message-ID: <20110131223319.GA3839@aftab> References: <1295882943-11184-1-git-send-email-bp@amd64.org> <1295882943-11184-2-git-send-email-bp@amd64.org> <20110131221659.GA14918@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110131221659.GA14918@kroah.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 31, 2011 at 05:16:59PM -0500, Greg KH wrote: > On Mon, Jan 24, 2011 at 04:28:57PM +0100, Borislav Petkov wrote: > > From: Borislav Petkov > > > > When encountering an error while executing the driver's ->add method, we > > should cancel registration and unwind what we've regged so far. The low > > level ->add methods do return proper error codes but those aren't looked > > at in sysdev_driver_register(). Fix that by sharing the unregistering > > code. > > Have you actually hit this before? If so, where? Sorta. I want to be paranoid when loading the microcode image file and in patch 3/7 (http://marc.info/?l=linux-kernel&m=129588287409770) I propagate the error in case loading the microcode fails. If we don't cleanup here, the driver remains loaded and takes up resources. And if you load it again, you get a sysfs warning about duplicated entries. > > Also, fixup warning messages formatting while at it. > > Please, no, one patch per thing. Please break this up into two > different patches. Yes, will do. > And, in the future, let me know that you need this for other work. Will do. > Actually, why did you send this to Ingo in your pull request? What does > your microcode patches need from this patch? It should go through my > tree, especially as there is other sysdev work happening at the moment. Sorry about that, I did not mean to bypass/offend you in any way. > so, no, please don't send this on to anyone else right now. Do you need the patches rediffed against a some tree of yours? @Ingo: please disregard my pull request from today: http://marc.info/?l=linux-kernel&m=129648061017908 Guys, sorry again if I've caused any trouble. Thanks. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632