* Re: [PATCH] Staging: bcm: fixed coding style issues
[not found] <1296525024-21898-1-git-send-email-tvh@informatik.uni-kiel.de>
@ 2011-02-01 2:42 ` Greg KH
2011-02-01 3:58 ` Stephen Hemminger
2011-02-01 5:33 ` Dan Carpenter
2 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2011-02-01 2:42 UTC (permalink / raw)
To: Timo von Holtz
Cc: shemminger, error27, arnd, jj, joe, eric.dumazet, devel,
linux-kernel
On Tue, Feb 01, 2011 at 02:50:24AM +0100, Timo von Holtz wrote:
> Fixed some coding style issues
Which ones?
With such a huge patch, it's best to break it down by type of coding
style cleanup, to make it easier to review and apply. This is almost
too big to review as-is :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: bcm: fixed coding style issues
[not found] <1296525024-21898-1-git-send-email-tvh@informatik.uni-kiel.de>
2011-02-01 2:42 ` [PATCH] Staging: bcm: fixed coding style issues Greg KH
@ 2011-02-01 3:58 ` Stephen Hemminger
2011-02-01 5:33 ` Dan Carpenter
2 siblings, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2011-02-01 3:58 UTC (permalink / raw)
To: Timo von Holtz
Cc: gregkh, error27, arnd, jj, joe, eric.dumazet, devel, linux-kernel
On Tue, 1 Feb 2011 02:50:24 +0100
Timo von Holtz <tvh@informatik.uni-kiel.de> wrote:
> diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
> index 32909e2..3a0b62d 100644
> --- a/drivers/staging/bcm/Adapter.h
> +++ b/drivers/staging/bcm/Adapter.h
> @@ -14,7 +14,7 @@ struct _LEADER
> UCHAR Status;
> UCHAR Unused[3];
> }__attribute__((packed));
> -typedef struct _LEADER LEADER,*PLEADER;
> +typedef struct _LEADER LEADER, *PLEADER;
Rather than fixing format of these typedef's eliminate
them according to CodingStyle
--
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: bcm: fixed coding style issues
[not found] <1296525024-21898-1-git-send-email-tvh@informatik.uni-kiel.de>
2011-02-01 2:42 ` [PATCH] Staging: bcm: fixed coding style issues Greg KH
2011-02-01 3:58 ` Stephen Hemminger
@ 2011-02-01 5:33 ` Dan Carpenter
2 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2011-02-01 5:33 UTC (permalink / raw)
To: Timo von Holtz
Cc: gregkh, shemminger, arnd, jj, joe, eric.dumazet, devel,
linux-kernel
On Tue, Feb 01, 2011 at 02:50:24AM +0100, Timo von Holtz wrote:
> static struct file_operations bcm_fops = {
> .owner = THIS_MODULE,
> - .open = bcm_char_open,
> + .open = bcm_char_open,,
^^
Only one comma needed.
> .release = bcm_char_release,
> .read = bcm_char_read,
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread