From: Christoph Hellwig <hch@lst.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio_blk: allow re-reading config space at runtime
Date: Tue, 1 Feb 2011 18:32:34 +0100 [thread overview]
Message-ID: <20110201173234.GC16883@lst.de> (raw)
In-Reply-To: <20110127152926.GA4898@redhat.com>
On Thu, Jan 27, 2011 at 05:29:26PM +0200, Michael S. Tsirkin wrote:
> Yes but in that specific situation (double schedule before
> it runs once) discarding one change notification
> would not hurt at all.
Except that you can't easily do it. We can't simply reuse a work
structure embedded in say struct virtio_blk without first doing a
flush_work_sync/cancel_work_sync to remove it from the internal
workqueue.c queues. And those calls can sleep and thus can't be called
from interrupt context either.
next prev parent reply other threads:[~2011-02-01 17:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 16:01 [PATCH] virtio_blk: allow re-reading config space at runtime Christoph Hellwig
2011-01-18 1:08 ` Rusty Russell
2011-01-18 12:27 ` Christoph Hellwig
2011-01-18 23:26 ` Rusty Russell
2011-01-18 23:54 ` Christoph Hellwig
2011-01-27 15:29 ` Michael S. Tsirkin
2011-02-01 17:32 ` Christoph Hellwig [this message]
2011-02-01 18:38 ` Michael S. Tsirkin
2011-02-01 19:21 ` Christoph Hellwig
2011-02-01 19:51 ` Michael S. Tsirkin
2011-02-01 20:43 ` [PATCH v3] " Christoph Hellwig
2011-02-04 2:39 ` Rusty Russell
2011-01-27 15:32 ` [PATCH] " Michael S. Tsirkin
2011-02-01 17:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110201173234.GC16883@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox