From: "Michael S. Tsirkin" <mst@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Amerigo Wang <amwang@redhat.com>,
linux-kernel@vger.kernel.org,
Stephen Hemminger <shemminger@vyatta.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Anthony Liguori <aliguori@us.ibm.com>,
Jamie Lokier <jamie@shareable.org>, Thomas Weber <swirl@gmx.li>,
Ben Hutchings <ben@decadent.org.uk>,
David Woodhouse <David.Woodhouse@intel.com>,
Andy Fleming <afleming@freescale.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC Patch] virtio: export model and type in /sys
Date: Tue, 1 Feb 2011 19:46:07 +0200 [thread overview]
Message-ID: <20110201174607.GA24924@redhat.com> (raw)
In-Reply-To: <20110201173738.GA18526@infradead.org>
On Tue, Feb 01, 2011 at 12:37:38PM -0500, Christoph Hellwig wrote:
> On Mon, Jan 31, 2011 at 10:53:00AM +0800, Amerigo Wang wrote:
> > Our kdump script needs /sys/block/X/device/{vendor, model, type},
> > but virtio devices don't have {model, type}, this patch adds them.
> > Actually, I don't know how to fill the model field, other block devices
> > seem read it from SCSI. Any comments?
>
> It does not make any sense to fill this at all in virtio. The
> attributes are simply exporting the SCSI INQUIRY data, and do not make
> any sense at all outside a SCSI context.
> In fact the type field even
> contains numbers from the scsi protocol spec that just don't make sense.
ide seems to export these too.
$ cat /sys/class/block/sr0/device/model
DVDRAM GSA-U20N
and I am pretty sure my dvd isn't scsi ...
next prev parent reply other threads:[~2011-02-01 17:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 2:53 [RFC Patch] virtio: export model and type in /sys Amerigo Wang
2011-01-31 4:05 ` Rusty Russell
2011-01-31 5:45 ` Cong Wang
2011-01-31 14:02 ` Anthony Liguori
2011-02-01 17:41 ` Christoph Hellwig
2011-01-31 9:52 ` Michael S. Tsirkin
2011-02-01 17:37 ` Christoph Hellwig
2011-02-01 17:46 ` Michael S. Tsirkin [this message]
2011-02-01 17:56 ` Christoph Hellwig
2011-02-04 6:29 ` Cong Wang
2011-02-12 7:17 ` Christoph Hellwig
2011-02-12 9:56 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110201174607.GA24924@redhat.com \
--to=mst@redhat.com \
--cc=David.Woodhouse@intel.com \
--cc=afleming@freescale.com \
--cc=aliguori@us.ibm.com \
--cc=amwang@redhat.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=jamie@shareable.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=shemminger@vyatta.com \
--cc=swirl@gmx.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox