From: Greg KH <gregkh@suse.de>
To: Kevin Hilman <khilman@ti.com>
Cc: linux-omap@vger.kernel.org, "Govindraj.R" <govindraj.raja@ti.com>,
open list <linux-kernel@vger.kernel.org>,
Thomas Weber <weber@corscience.de>
Subject: Re: [PATCHv4] OMAP: Enable Magic SysRq on serial console ttyOx
Date: Tue, 1 Feb 2011 16:12:17 -0800 [thread overview]
Message-ID: <20110202001217.GA19277@suse.de> (raw)
In-Reply-To: <87oc6vnyfj.fsf@ti.com>
On Tue, Feb 01, 2011 at 03:10:40PM -0800, Kevin Hilman wrote:
> Greg KH <gregkh@suse.de> writes:
>
> > On Tue, Feb 01, 2011 at 08:31:30AM -0800, Kevin Hilman wrote:
> >> Thomas Weber <weber@corscience.de> writes:
> >>
> >> > Magic SysRq key is not working for OMAP on new serial
> >> > console ttyOx because SUPPORT_SYSRQ is not defined
> >> > for omap-serial.
> >> >
> >> > This patch defines SUPPORT_SYSRQ in omap-serial and
> >> > enables handling of Magic SysRq character.
> >> >
> >> > Further there is an issue of losing first break character.
> >> > Removing the reset of the lsr_break_flag fixes this issue.
> >> >
> >> > Signed-off-by: Thomas Weber <weber@corscience.de>
> >> > Acked-by: Govindraj.R <govindraj.raja@ti.com>
> >> > Tested-by: Manjunath G Kondaiah <manjugk@ti.com>
> >> > Acked-by: Kevin Hilman <khilman@ti.com>
> >>
> >> Greg,
> >>
> >> Will you be taking this? If you prefer, we can take it via OMAP tree
> >> with your ack.
> >
> > I can take it if it's not a problem for you. Or if you want to, please
> > add:
> > Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
> > to the patch.
> >
> > Let me know which is easier for you.
>
> Since there are no dependencies on arch/arm/*omap*, you can merge it.
Ok, will do.
thanks,
greg k-h
prev parent reply other threads:[~2011-02-02 0:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 7:30 [PATCHv4] OMAP: Enable Magic SysRq on serial console ttyOx Thomas Weber
[not found] ` <87ei7ryavx.fsf@ti.com>
2011-02-01 22:23 ` Greg KH
2011-02-01 23:10 ` Kevin Hilman
2011-02-02 0:12 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110202001217.GA19277@suse.de \
--to=gregkh@suse.de \
--cc=govindraj.raja@ti.com \
--cc=khilman@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=weber@corscience.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox