From: Ingo Molnar <mingo@elte.hu>
To: castet.matthieu@free.fr
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-security-module@vger.kernel.org,
Matthias Hopf <mhopf@suse.de>,
rjw@sisk.pl, Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] NX protection for kernel data : fix 32 bits S3 suspend
Date: Wed, 2 Feb 2011 07:26:32 +0100 [thread overview]
Message-ID: <20110202062632.GA12256@elte.hu> (raw)
In-Reply-To: <1296566732.4d4809cc1f963@imp.free.fr>
* castet.matthieu@free.fr <castet.matthieu@free.fr> wrote:
> Quoting Ingo Molnar <mingo@elte.hu>:
>
> >
> > * matthieu castet <castet.matthieu@free.fr> wrote:
> >
> > > static inline int is_kernel_text(unsigned long addr)
> > > {
> > > +#if defined(CONFIG_X86_32) && defined(CONFIG_ACPI_SLEEP)
> > > + /*
> > > + * We need to make the wakeup trampoline in first 1MB !NX
> > > + */
> > > + if (addr >= PAGE_OFFSET && addr <= (PAGE_OFFSET + (1<<20)))
> > > + return 1;
> > > +#endif
> >
> > That's pretty ugly. Why not use set_memory_x()/set_memory_nx(), and only for
> > the
> > trampoline itself? Does the whole 1MB need to be marked X?
>
> The previous code was doing that.
So why not call set_memory_x() in your patch? Mind trying that?
Thanks,
Ingo
next prev parent reply other threads:[~2011-02-02 6:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 23:03 [PATCH] NX protection for kernel data : fix 32 bits S3 suspend matthieu castet
2011-02-01 8:02 ` Ingo Molnar
2011-02-01 13:25 ` castet.matthieu
2011-02-01 16:30 ` H. Peter Anvin
2011-02-02 6:26 ` Ingo Molnar [this message]
2011-02-03 22:11 ` H. Peter Anvin
2011-02-05 1:12 ` H. Peter Anvin
2011-02-05 16:46 ` castet.matthieu
2011-02-06 23:41 ` H. Peter Anvin
2011-02-07 7:40 ` Ingo Molnar
2011-02-07 19:59 ` castet.matthieu
2011-02-07 20:04 ` H. Peter Anvin
2011-02-12 16:10 ` matthieu castet
2011-02-14 20:55 ` H. Peter Anvin
2011-02-26 3:58 ` Pavel Machek
2011-02-07 20:07 ` H. Peter Anvin
2011-02-14 21:19 ` H. Peter Anvin
2011-02-14 22:50 ` Rafael J. Wysocki
2011-02-07 3:56 ` H. Peter Anvin
2011-02-07 5:16 ` H. Peter Anvin
2011-02-07 9:24 ` [tip:x86/urgent] x86, nx: Mark the ACPI resume trampoline code as +x tip-bot for H. Peter Anvin
2011-02-07 14:50 ` [tip:x86/urgent] x86, nx: Mark the ACPI resume trampoline code as +x - fixed Marc Koschewski
2011-02-07 15:04 ` Ingo Molnar
2011-02-07 13:16 ` [PATCH] NX protection for kernel data : fix 32 bits S3 suspend Matthias Hopf
[not found] <ghb2G-3tw-7@gated-at.bofh.it>
[not found] ` <ghjtg-WV-5@gated-at.bofh.it>
[not found] ` <ghosV-TN-9@gated-at.bofh.it>
[not found] ` <ghEo1-2IF-1@gated-at.bofh.it>
[not found] ` <gifGW-7eL-13@gated-at.bofh.it>
2011-02-06 10:30 ` Bodo Eggert
2011-02-06 23:32 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110202062632.GA12256@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=castet.matthieu@free.fr \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mhopf@suse.de \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox