From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754753Ab1BBRiq (ORCPT ); Wed, 2 Feb 2011 12:38:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11182 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754491Ab1BBRip (ORCPT ); Wed, 2 Feb 2011 12:38:45 -0500 Date: Wed, 2 Feb 2011 19:38:27 +0200 From: Gleb Natapov To: "H. Peter Anvin" Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , x86@kernel.org Subject: Re: [PATCH] Fix EDD3.0 data verification. Message-ID: <20110202173827.GB24871@redhat.com> References: <20110202112139.GD14984@redhat.com> <4D4990F8.5020204@zytor.com> <20110202172534.GA24871@redhat.com> <4D49946D.8010800@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D49946D.8010800@zytor.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 02, 2011 at 09:29:17AM -0800, H. Peter Anvin wrote: > On 02/02/2011 09:25 AM, Gleb Natapov wrote: > > According to spec length should be set to 30 on exit. > > I don't really know how this comment relates to the code, but in the > code I saw a fixed number of bytes being checksummed, which is > definitely wrong. > What length do you propose to use? If you were referring to params->length then it is incorrect since it will be always 30 on exit and this has nothing to do with size we need to checksum. Spec defines that the sum of bytes 30-73 should be zero. What is definitely wrong about this? -- Gleb.