Re: [PATCH v3 1/2] block: skip elevator data initialization for flush requests

Tejun Heo
2011-02-04T15:08:54Z

Hello,

On Fri, Feb 04, 2011 at 10:04:57AM -0500, Vivek Goyal wrote:
> > The rationale behind suggesting was that it indicates to the allocator
> > that the request may be sorted as how the request will be used is
> > communicated using @rw_flags to the allocator. The patch is buggy
> > that the flag actually ends up on the request. Any better idea how to
> > communicate it?
>
> Though you did not like the V1 of patch, personally I also liked just parsing
> FLUSH or FUA flag in get_request().
>
> Or how about intoducing a helper function blk_rq_should_init_elevator()
> or something like that and this function will parse FLUSH, FUA flags.

I suppose it's Jens' call, but if the FLUSH/FUA testing goes inside
the alloc function, please decorate with big fat comment and mention
it in the comment for the union definition too.

Thank you.

--
tejun