Re: [tip:x86/mm] x86, mm: Fix incorrect data type in vmalloc_sync_all()

H. Peter Anvin
2010-10-20T19:53:45Z

On 10/20/2010 12:50 PM, Borislav Petkov wrote:
>> Commit-ID: bfac67208d6d2a84fe7980187d3d2f21424dde59
>> Gitweb: http://git.kernel.org/tip/bfac67208d6d2a84fe7980187d3d2f21424dde59
>> Author: tip-bot for Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
>
> Looks like git (or your script) picked up the first From: in the mail as
> author...
>

Yes, your email started out:

From: tip-bot for Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Date: Tue, Oct 19, 2010 at 10:17:37PM +0000

> > Commit-ID: 617d34d9e5d8326ec8f188c616aa06ac59d083fe
> > Gitweb:
http://git.kernel.org/tip/617d34d9e5d8326ec8f188c616aa06ac59d083fe
> > Author: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> > AuthorDate: Tue, 21 Sep 2010 12:01:51 -0700
> > Committer: H. Peter Anvin <hpa@linux.intel.com>
> > CommitDate: Tue, 19 Oct 2010 13:57:08 -0700
--
From: Borislav Petkov <borislav.petkov@amd.com>
Date: Wed, 20 Oct 2010 12:23:48 +0200
Subject: [PATCH] x86, mm: Fix build warning on 32-bit

... and that confused the scripts. The way git wants it commentary
information should go *after* the "---" line.

(This is a constant problem, by the way: people seems to want to prefix,
not suffix, their commentary; "cover letter" style.) I suspect git
needs to change, but it's hard to know exactly how to change it.

-hpa