[GIT PULL] XFS update for 2.6.38-rc3

[GIT PULL] XFS update for 2.6.38-rc3

[Alex Elder]

Linus, please accept the following updates for XFS, for 2.6.38-rc3
(if it's not too late) or 2.6.38-rc4.

They are all fixes for bugs that have some pretty undesirable
consequences.  They address:
- One spot in which a hang can occur due to neglecting to drop a
  lock
- A bug which in some cases a bogus block number can be recorded in
  a block map btree, resulting in a subsequent BUG_ON().
- Two memory leaks
- Three places in which extent sizes are allowed to exceed various
  size limits
- One place where code depends on behavior that is not well-defined
  by the C standard
- One problem in handling transaction commit errors

Thank you.

					-Alex

The following changes since commit 70d1f365568e0cdbc9f4ab92428e1830fdb09ab0:

  Merge branch 'for-linus' of git://git.infradead.org/ubi-2.6 (2011-01-31 13:04:51 +1000)

are available in the git repository at:

  git://oss.sgi.com/xfs/xfs for-linus

Dave Chinner (8):
      xfs: fix log ticket leak on forced shutdown.
      xfs: fix efi item leak on forced shutdown
      xfs: speculative delayed allocation uses rounddown_power_of_2 badly
      xfs: limit extent length for allocation to AG size
      xfs: prevent extsize alignment from exceeding maximum extent size
      xfs: limit extsize to size of AGs and/or MAXEXTLEN
      xfs: handle CIl transaction commit failures correctly
      xfs: fix dquot shaker deadlock

bpm@sgi.com (1):
      xfs: xfs_bmap_add_extent_delay_real should init br_startblock

 fs/xfs/linux-2.6/xfs_ioctl.c |   20 ++++++++++++-
 fs/xfs/quota/xfs_qm.c        |   46 ++++++++++++++-----------------
 fs/xfs/xfs_alloc.h           |   16 +++++++++++
 fs/xfs/xfs_bmap.c            |   61 +++++++++++++++++++++++++++++++-----------
 fs/xfs/xfs_buf_item.c        |   12 +++++---
 fs/xfs/xfs_extfree_item.c    |    3 +-
 fs/xfs/xfs_iomap.c           |    7 ++++-
 fs/xfs/xfs_log.h             |    2 +-
 fs/xfs/xfs_log_cil.c         |   15 ++++------
 fs/xfs/xfs_trans.c           |   41 ++++++++++++++++++++-------
 10 files changed, 152 insertions(+), 71 deletions(-)

Re: [GIT PULL] XFS update for 2.6.38-rc3

[Mark Lord]

On 11-01-31 11:42 AM, Alex Elder wrote:
> Linus, please accept the following updates for XFS, for 2.6.38-rc3
> (if it's not too late) or 2.6.38-rc4.
> 
> They are all fixes for bugs that have some pretty undesirable
> consequences.  They address:
> - One spot in which a hang can occur due to neglecting to drop a
>   lock
> - A bug which in some cases a bogus block number can be recorded in
>   a block map btree, resulting in a subsequent BUG_ON().
> - Two memory leaks
> - Three places in which extent sizes are allowed to exceed various
>   size limits
> - One place where code depends on behavior that is not well-defined
>   by the C standard
> - One problem in handling transaction commit errors


Are these bugs all new in 2.6.38, or should some of these fixes
also go out to -stable for earlier revisions?


> Dave Chinner (8):
>       xfs: fix log ticket leak on forced shutdown.
>       xfs: fix efi item leak on forced shutdown
>       xfs: speculative delayed allocation uses rounddown_power_of_2 badly
>       xfs: limit extent length for allocation to AG size
>       xfs: prevent extsize alignment from exceeding maximum extent size
>       xfs: limit extsize to size of AGs and/or MAXEXTLEN
>       xfs: handle CIl transaction commit failures correctly
>       xfs: fix dquot shaker deadlock
> 
> bpm@sgi.com (1):
>       xfs: xfs_bmap_add_extent_delay_real should init br_startblock

Re: [GIT PULL] XFS update for 2.6.38-rc3

[Dave Chinner]

On Tue, Feb 01, 2011 at 11:00:33AM -0500, Mark Lord wrote:
> On 11-01-31 11:42 AM, Alex Elder wrote:
> > Linus, please accept the following updates for XFS, for 2.6.38-rc3
> > (if it's not too late) or 2.6.38-rc4.
> > 
> > They are all fixes for bugs that have some pretty undesirable
> > consequences.  They address:
> > - One spot in which a hang can occur due to neglecting to drop a
> >   lock
> > - A bug which in some cases a bogus block number can be recorded in
> >   a block map btree, resulting in a subsequent BUG_ON().
> > - Two memory leaks
> > - Three places in which extent sizes are allowed to exceed various
> >   size limits
> > - One place where code depends on behavior that is not well-defined
> >   by the C standard
> > - One problem in handling transaction commit errors
> 
> 
> Are these bugs all new in 2.6.38, or should some of these fixes
> also go out to -stable for earlier revisions?
> 
> 
> > Dave Chinner (8):
> >       xfs: fix log ticket leak on forced shutdown.
> >       xfs: fix efi item leak on forced shutdown

Been there for years, extremely hard to hit, so no.

> >       xfs: speculative delayed allocation uses rounddown_power_of_2 badly

-38-rc1 regression, so no.

> >       xfs: limit extent length for allocation to AG size
> >       xfs: prevent extsize alignment from exceeding maximum extent size
> >       xfs: limit extsize to size of AGs and/or MAXEXTLEN

Been there for years in little used functionality, so no.

> >       xfs: handle CIl transaction commit failures correctly

Introduced with new code in 2.6.35, hard to hit, only results in
small memory leaks, so no.

> >       xfs: fix dquot shaker deadlock

That's a regression, so maybe.

> > bpm@sgi.com (1):
> >       xfs: xfs_bmap_add_extent_delay_real should init br_startblock

Been there for years, no evidence ATM that this code path can be
exercised with a mainline kernel, so no.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

Re: [GIT PULL] XFS update for 2.6.38-rc3

[Arkadiusz Miskiewicz]

On Thursday 03 of February 2011, Dave Chinner wrote:
> On Tue, Feb 01, 2011 at 11:00:33AM -0500, Mark Lord wrote:
> > On 11-01-31 11:42 AM, Alex Elder wrote:
> > > Linus, please accept the following updates for XFS, for 2.6.38-rc3
> > > (if it's not too late) or 2.6.38-rc4.
> > > 
> > > They are all fixes for bugs that have some pretty undesirable
> > > consequences. 

[...]

> > Are these bugs all new in 2.6.38, or should some of these fixes
> > also go out to -stable for earlier revisions?
> > >       xfs: fix dquot shaker deadlock
> 
> That's a regression, so maybe.

Definitely, xfs_fsr can hit this even few times a day (happened already).

Stable team, please include this one for 2.6.37.1:

commit 0fbca4d1c3932c27c4794bf5c2b5fc961cf5a54f
Author: Dave Chinner <dchinner@redhat.com>
Date:   Fri Jan 28 11:20:46 2011 +1100

    xfs: fix dquot shaker deadlock

    Commit 368e136 ("xfs: remove duplicate code from dquot reclaim") fails
    to unlock the dquot freelist when the number of loop restarts is
    exceeded in xfs_qm_dqreclaim_one(). This causes hangs in memory
    reclaim.

    Rework the loop control logic into an unwind stack that all the
    different cases jump into. This means there is only one set of code
    that processes the loop exit criteria, and simplifies the unlocking
    of all the items from different points in the loop. It also fixes a
    double increment of the restart counter from the qi_dqlist_lock
    case.

    Reported-by: Malcolm Scott <lkml@malc.org.uk>
    Signed-off-by: Dave Chinner <dchinner@redhat.com>
    Reviewed-by: Alex Elder <aelder@sgi.com>


> Cheers,
> 
> Dave.


-- 
Arkadiusz Miśkiewicz        PLD/Linux Team
arekm / maven.pl            http://ftp.pld-linux.org/

Re: [stable] [GIT PULL] XFS update for 2.6.38-rc3

[Greg KH]

On Thu, Feb 03, 2011 at 11:02:31PM +0100, Arkadiusz Miskiewicz wrote:
> On Thursday 03 of February 2011, Dave Chinner wrote:
> > On Tue, Feb 01, 2011 at 11:00:33AM -0500, Mark Lord wrote:
> > > On 11-01-31 11:42 AM, Alex Elder wrote:
> > > > Linus, please accept the following updates for XFS, for 2.6.38-rc3
> > > > (if it's not too late) or 2.6.38-rc4.
> > > > 
> > > > They are all fixes for bugs that have some pretty undesirable
> > > > consequences. 
> 
> [...]
> 
> > > Are these bugs all new in 2.6.38, or should some of these fixes
> > > also go out to -stable for earlier revisions?
> > > >       xfs: fix dquot shaker deadlock
> > 
> > That's a regression, so maybe.
> 
> Definitely, xfs_fsr can hit this even few times a day (happened already).
> 
> Stable team, please include this one for 2.6.37.1:

Now queued up (it will make .2, sorry, not .1)

thanks,

greg k-h