From: Greg KH <gregkh@suse.de>
To: Olof Johansson <olof@lixom.net>
Cc: Greg KH <greg@kroah.com>, Robert Morell <rmorell@nvidia.com>,
David Brownell <dbrownell@users.sourceforge.net>,
Benoit Goby <benoit@android.com>,
Alan Stern <stern@rowland.harvard.edu>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
Matthew Wilcox <willy@linux.intel.com>,
Ming Lei <tom.leiming@gmail.com>,
Jacob Pan <jacob.jun.pan@intel.com>,
Oliver Neukum <oliver@neukum.org>,
Erik Gilling <konkers@android.com>,
Colin Cross <ccross@android.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 3/3] USB: ehci: tegra: Align DMA transfers to 32 bytes
Date: Fri, 4 Feb 2011 12:16:16 -0800 [thread overview]
Message-ID: <20110204201616.GA12482@suse.de> (raw)
In-Reply-To: <AANLkTinRtch4Pvr3GLz5wZU2xkG3FMJxxzSNAdParA7j@mail.gmail.com>
On Fri, Feb 04, 2011 at 12:14:54PM -0800, Olof Johansson wrote:
> On Fri, Feb 4, 2011 at 11:49 AM, Greg KH <greg@kroah.com> wrote:
> > On Wed, Jan 26, 2011 at 07:06:49PM -0800, Robert Morell wrote:
> >> The Tegra2 USB controller doesn't properly deal with misaligned DMA
> >> buffers, causing corruption. This is especially prevalent with USB
> >> network adapters, where skbuff alignment is often in the middle of a
> >> 4-byte dword.
> >>
> >> To avoid this, allocate a temporary buffer for the DMA if the provided
> >> buffer isn't sufficiently aligned.
> >>
> >> Signed-off-by: Robert Morell <rmorell@nvidia.com>
> >> ---
> >> drivers/usb/host/ehci-tegra.c | 90 +++++++++++++++++++++++++++++++++++++++++
> >
> > This file doesn't seem to be in any tree that I can find, including my
> > own, so I can't apply this patch.
> >
> > What am I supposed to do with it?
>
> It hasn't been posted for upstream yet, so nothing for you to do. The
> driver will be posted for review soon, hopefully in time for .39.
Then why would someone send me a patch for it already?
Still confused,
greg k-h
next prev parent reply other threads:[~2011-02-04 20:18 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 21:58 [RFC] Align tegra-ehci DMA transfers to 32B Robert Morell
2010-12-17 21:58 ` [PATCH 1/2] USB: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2010-12-17 21:58 ` [PATCH 2/2] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2010-12-17 22:35 ` Greg KH
2010-12-17 22:42 ` rmorell
2010-12-17 23:09 ` Greg KH
2010-12-17 23:17 ` Oliver Neukum
2010-12-17 23:35 ` Greg KH
2010-12-17 23:50 ` rmorell
2010-12-17 23:40 ` rmorell
2010-12-18 0:37 ` Greg KH
2010-12-18 1:29 ` rmorell
2010-12-17 22:32 ` [RFC] Align tegra-ehci DMA transfers to 32B Greg KH
2010-12-17 22:44 ` rmorell
2010-12-17 23:07 ` Greg KH
2010-12-17 23:07 ` David Brownell
2010-12-18 1:49 ` [PATCH v2] " Robert Morell
2010-12-19 21:38 ` [PATCH] " Robert Morell
2011-01-06 23:20 ` [PATCH v4] " Robert Morell
2011-01-20 21:41 ` [PATCH v5] " Robert Morell
2011-01-27 3:06 ` [PATCH v6] " Robert Morell
2011-01-27 3:06 ` [PATCH 1/3] USB: HCD: Add usb_hcd prefix to exported functions Robert Morell
2011-01-27 16:01 ` Alan Stern
2011-01-27 3:06 ` [PATCH 2/3] USB: HCD: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2011-01-27 16:01 ` Alan Stern
2011-01-27 3:06 ` [PATCH 3/3] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2011-02-04 19:49 ` Greg KH
2011-02-04 20:14 ` Olof Johansson
2011-02-04 20:16 ` Greg KH [this message]
2011-02-04 20:26 ` rmorell
2011-02-04 20:35 ` Greg KH
2011-01-20 21:41 ` [PATCH 1/2] USB: HCD: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2011-01-23 3:46 ` Greg KH
2011-01-24 16:32 ` Alan Stern
2011-01-20 21:41 ` [PATCH 2/2] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2011-01-24 16:36 ` Alan Stern
2011-01-24 22:53 ` rmorell
2011-01-25 2:59 ` Alan Stern
2011-01-06 23:20 ` [PATCH v4 1/2] USB: HCD: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2011-01-06 23:20 ` [PATCH v4 2/2] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2010-12-19 21:38 ` [PATCH 1/2] USB: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2010-12-19 21:38 ` [PATCH 2/2] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2010-12-19 21:57 ` Oliver Neukum
2010-12-18 1:49 ` [PATCH v2 1/2] USB: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2010-12-18 17:51 ` Greg KH
2010-12-18 1:49 ` [PATCH v2 2/2] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2010-12-18 17:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110204201616.GA12482@suse.de \
--to=gregkh@suse.de \
--cc=benoit@android.com \
--cc=ccross@android.com \
--cc=dbrownell@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=jacob.jun.pan@intel.com \
--cc=konkers@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=olof@lixom.net \
--cc=rmorell@nvidia.com \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tom.leiming@gmail.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox