From: Greg KH <greg@kroah.com>
To: Timo von Holtz <tvh@informatik.uni-kiel.de>
Cc: gregkh@suse.de, mchehab@redhat.com, d.belimov@gmail.com,
stefan.ringel@arcor.de, michel.ludwig@gmail.com,
khali@linux-fr.org, c.pascoe@itee.uq.edu.au,
ruslan@rpisarev.org.ua, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: tm6000: fixed some coding style issues
Date: Fri, 4 Feb 2011 12:52:15 -0800 [thread overview]
Message-ID: <20110204205215.GA28058@kroah.com> (raw)
In-Reply-To: <1296564547-26619-1-git-send-email-tvh@informatik.uni-kiel.de>
On Tue, Feb 01, 2011 at 01:49:07PM +0100, Timo von Holtz wrote:
> Fixed all of the following coding style issues:
>
> ERROR: return is not a function, parentheses are not required
> WARNING: __func__ should be used instead of gcc specific __FUNCTION__
> ERROR: trailing whitespace
> ERROR: spaces required around that '=' (ctx:VxV)
> WARNING: please, no space before tabs
> WARNING: please, no spaces at the start of a line
> ERROR: space required after that ',' (ctx:VxV)
> WARNING: space prohibited between function name and open parenthesis '('
> ERROR: spaces required around that '<' (ctx:VxV)
> ERROR: spaces required around that '==' (ctx:VxV)
>
> Signed-off-by: Timo von Holtz <tvh@informatik.uni-kiel.de>
This needs to go to Mauro Carvalho Chehab <mchehab@redhat.com> as he
handles patches to this driver.
thanks,
greg k-h
next prev parent reply other threads:[~2011-02-04 21:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 12:49 [PATCH] Staging: tm6000: fixed some coding style issues Timo von Holtz
2011-02-01 13:09 ` Jean Delvare
2011-02-04 20:52 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-02-01 11:22 Timo von Holtz
2011-02-01 12:23 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110204205215.GA28058@kroah.com \
--to=greg@kroah.com \
--cc=c.pascoe@itee.uq.edu.au \
--cc=d.belimov@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=michel.ludwig@gmail.com \
--cc=ruslan@rpisarev.org.ua \
--cc=stefan.ringel@arcor.de \
--cc=tvh@informatik.uni-kiel.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox