From: Ingo Molnar <mingo@elte.hu>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: John Villalovos <jvillalo@redhat.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Yinghai Lu <yinghai@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"John L. Villalovos" <john.l.villalovos@intel.com>,
prarit@redhat.com
Subject: Re: [PATCH 1/1] x86, apic: Make "broken BIOS!!" messages unique
Date: Fri, 4 Feb 2011 23:00:07 +0100 [thread overview]
Message-ID: <20110204220007.GA6052@elte.hu> (raw)
In-Reply-To: <4D4C4C4D.40106@zytor.com>
* H. Peter Anvin <hpa@zytor.com> wrote:
> On 02/04/2011 09:48 AM, John Villalovos wrote:
> > x86, apic: Make "broken BIOS!!" messages unique
> >
> > There are five identical "broken BIOS!!" messages. This patch makes each
> > message unique so that it is easier to determine which message was actually
> > printed.
> >
> > The 'inconceivable' messages are because it should not be possible to reach
> > those code paths.
>
> How about labelling these "MPBIOS" or so, too?
Yeah.
Also, the messages do not need to shout i suspect - the '!!' can be removed as well.
Thanks,
Ingo
prev parent reply other threads:[~2011-02-04 22:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 17:48 [PATCH 1/1] x86, apic: Make "broken BIOS!!" messages unique John Villalovos
2011-02-04 18:58 ` H. Peter Anvin
2011-02-04 22:00 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110204220007.GA6052@elte.hu \
--to=mingo@elte.hu \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=john.l.villalovos@intel.com \
--cc=jvillalo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=prarit@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox