From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751537Ab1BFFKI (ORCPT ); Sun, 6 Feb 2011 00:10:08 -0500 Received: from kroah.org ([198.145.64.141]:57815 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827Ab1BFFKH (ORCPT ); Sun, 6 Feb 2011 00:10:07 -0500 Date: Sat, 5 Feb 2011 21:11:11 -0800 From: Greg KH To: Nitin Gupta Cc: Pekka Enberg , Linux Driver Project , linux-kernel Subject: Re: [PATCH] zram: fix data corruption issue Message-ID: <20110206051111.GA4816@kroah.com> References: <1296956060-13594-1-git-send-email-ngupta@vflare.org> <20110206050059.GA4465@kroah.com> <4D4E2B90.7010109@vflare.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D4E2B90.7010109@vflare.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 06, 2011 at 12:03:12AM -0500, Nitin Gupta wrote: > On 02/06/2011 12:00 AM, Greg KH wrote: > >On Sat, Feb 05, 2011 at 08:34:20PM -0500, Nitin Gupta wrote: > >>In zram_read() and zram_write() we were not incrementing the > >>index number and thus were reading/writing values from/to > >>incorrect sectors on zram disk, resulting in data corruption. > > > >Is this something that needs to go into .38 or can it wait until .39? > > > > > This really needs to get into .38 or users will see random data > corruption on zram devices. Ok, I'll queue it up for there. What about .37 and/or .36? thanks, greg k-h