From: Arnd Bergmann <arnd@arndb.de>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: linux-kernel@vger.kernel.org, Kees Cook <kees.cook@canonical.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] Export linux/syslog.h
Date: Mon, 7 Feb 2011 13:55:55 +0100 [thread overview]
Message-ID: <201102071355.55978.arnd@arndb.de> (raw)
In-Reply-To: <1297079503.1741.10.camel@t41.thuisdomein>
On Monday 07 February 2011, Paul Bolle wrote:
> Userspace programs (like util-linux' dmesg) still use magic numbers for
> the klogctl function (glibc's interface to the syslog system call).
> Exporting linux/syslog.h makes the more descriptive named constants
> available as a single reference for these values.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> Signed-off-by: Kees Cook <kees.cook@canonical.com>
It sounds reasonable to make this a proper ABI in general.
The comment in the header file currently starts with "Syslog internals".
If you want to export it, you should probably change that, too.
Further, the man page currently documents the raw numbers and should
be changed as well with the new constants.
Arnd
next prev parent reply other threads:[~2011-02-07 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 11:51 [PATCH] Export linux/syslog.h Paul Bolle
2011-02-07 12:55 ` Arnd Bergmann [this message]
2011-02-07 13:17 ` Paul Bolle
2011-02-07 14:33 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102071355.55978.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=dwmw2@infradead.org \
--cc=kees.cook@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox