From: John Villalovos <john.l.villalovos@intel.com>
To: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Yinghai Lu <yinghai@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org,
John Villalovos <jvillalo@redhat.com>,
prarit@redhat.com
Subject: [PATCH 1/1 V2] x86, apic: Make "broken BIOS!!" messages unique
Date: Mon, 7 Feb 2011 05:58:43 -0800 [thread overview]
Message-ID: <20110207135843.GA10121@linuxjohn3.jf.intel.com> (raw)
x86, apic: Make "broken BIOS!!" messages unique
There are five identical "broken BIOS!!" messages. This patch makes each
message unique so that it is easier to determine which message was actually
printed. Changed to "broken MPBIOS: <unique identifier>!!"
The 'inconceivable' messages are because it should not be possible to reach
those code paths.
V2: Change to specify MPBIOS and remove exclamation marks.
Signed-off-by: John L. Villalovos <john.l.villalovos@intel.com>
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 697dc34..5391276 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -841,7 +841,7 @@ static int MPBIOS_polarity(int idx)
}
case 2: /* reserved */
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken MPBIOS: polarity\n");
polarity = 1;
break;
}
@@ -852,7 +852,7 @@ static int MPBIOS_polarity(int idx)
}
default: /* invalid */
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken MPBIOS: inconceivable polarity\n");
polarity = 1;
break;
}
@@ -899,7 +899,7 @@ static int MPBIOS_trigger(int idx)
}
default:
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken MPBIOS: unknown bus type\n");
trigger = 1;
break;
}
@@ -913,7 +913,7 @@ static int MPBIOS_trigger(int idx)
}
case 2: /* reserved */
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken MPBIOS: trigger\n");
trigger = 1;
break;
}
@@ -924,7 +924,7 @@ static int MPBIOS_trigger(int idx)
}
default: /* invalid */
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken MPBIOS: inconceivable trigger\n");
trigger = 0;
break;
}
next reply other threads:[~2011-02-07 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 13:58 John Villalovos [this message]
2011-02-07 21:25 ` [PATCH 1/1 V2] x86, apic: Make "broken BIOS!!" messages unique H. Peter Anvin
2011-02-07 21:33 ` John Villalovos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207135843.GA10121@linuxjohn3.jf.intel.com \
--to=john.l.villalovos@intel.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=jvillalo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=prarit@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox