From: Tejun Heo <tj@kernel.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Len Brown <len.brown@intel.com>,
ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM mailing list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] thermal: Use freezable workqueue
Date: Tue, 8 Feb 2011 10:32:12 +0100 [thread overview]
Message-ID: <20110208093212.GA6558@htj.dyndns.org> (raw)
In-Reply-To: <201102081020.25646.rjw@sisk.pl>
Hello, Dmitry, Rafael.
On Tue, Feb 08, 2011 at 10:20:25AM +0100, Rafael J. Wysocki wrote:
> > > + thermal_wq = alloc_workqueue("thermal", WQ_FREEZEABLE, 0);
> >
> > Should probably be unbound as well.
>
> Yup, thanks.
Hmm.. why should it be unbound? Unbound wqs are primarily useful for
very long running (system daemon type) works which may also consume
considerable amount of cpu cycles.
> > FWIW, I would not mind if we had a global freezeable workqueue already
> > predefined. I could switch input_polldev and vmw_balloon to it and there
> > probably could be more users...
>
> Hmm, OK.
>
> Do you think we should add system_freezeable_wq to the set of predefined
> workqueues?
Oh, yeah, definitely. I'll write up a patch.
Thanks.
--
tejun
next prev parent reply other threads:[~2011-02-08 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 23:29 [PATCH] thermal: Use freezable workqueue Rafael J. Wysocki
2011-02-08 4:47 ` Dmitry Torokhov
2011-02-08 9:20 ` Rafael J. Wysocki
2011-02-08 9:32 ` Tejun Heo [this message]
2011-02-08 9:41 ` [PATCH wq#for-2.6.39] workqueue: add system_freezeable_wq Tejun Heo
2011-02-08 15:10 ` [linux-pm] " Alan Stern
2011-02-08 15:14 ` Tejun Heo
2011-02-08 15:32 ` Alan Stern
2011-02-08 17:58 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110208093212.GA6558@htj.dyndns.org \
--to=tj@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).