From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Seth Heasley <seth.heasley@intel.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
khali@linux-fr.org
Subject: Re: [PATCH 2.6.37] lpc: irq and pci_ids patch for Intel DH89xxCC DeviceIDs
Date: Tue, 8 Feb 2011 13:10:15 -0800 [thread overview]
Message-ID: <20110208131015.7345a4df@jbarnes-desktop> (raw)
In-Reply-To: <201101101308.37805.seth.heasley@intel.com>
On Mon, 10 Jan 2011 13:08:37 -0800
Seth Heasley <seth.heasley@intel.com> wrote:
> This patch adds the LPC Controller DeviceIDs for the Intel DH89xxCC PCH.
>
> The code for capturing ranges of LPC Controller DeviceIDs has also been updated.
>
> Signed-off-by: Seth Heasley <seth.heasley@intel.com>
>
> --- linux-2.6.37/include/linux/pci_ids.h.orig 2011-01-04 16:50:19.000000000 -0800
> +++ linux-2.6.37/include/linux/pci_ids.h 2011-01-10 11:23:19.000000000 -0800
> @@ -2469,6 +2469,9 @@
> #define PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MAX 0x1c5f
> #define PCI_DEVICE_ID_INTEL_PATSBURG_SMBUS 0x1d22
> #define PCI_DEVICE_ID_INTEL_PATSBURG_LPC 0x1d40
> +#define PCI_DEVICE_ID_INTEL_DH89XXCC_LPC_MIN 0x2310
> +#define PCI_DEVICE_ID_INTEL_DH89XXCC_LPC_MAX 0x231f
> +#define PCI_DEVICE_ID_INTEL_DH89XXCC_SMBUS 0x2330
> #define PCI_DEVICE_ID_INTEL_82801AA_0 0x2410
> #define PCI_DEVICE_ID_INTEL_82801AA_1 0x2411
> #define PCI_DEVICE_ID_INTEL_82801AA_3 0x2413
> --- linux-2.6.37/arch/x86/pci/irq.c.orig 2011-01-04 16:50:19.000000000 -0800
> +++ linux-2.6.37/arch/x86/pci/irq.c 2011-01-10 11:31:02.000000000 -0800
> @@ -596,21 +596,18 @@
> return 1;
> }
>
> - if ((device >= PCI_DEVICE_ID_INTEL_5_3400_SERIES_LPC_MIN) &&
> - (device <= PCI_DEVICE_ID_INTEL_5_3400_SERIES_LPC_MAX)) {
> + if ((device >= PCI_DEVICE_ID_INTEL_5_3400_SERIES_LPC_MIN &&
> + device <= PCI_DEVICE_ID_INTEL_5_3400_SERIES_LPC_MAX)
> + || (device >= PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MIN &&
> + device <= PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MAX)
> + || (device >= PCI_DEVICE_ID_INTEL_DH89XXCC_LPC_MIN &&
> + device <= PCI_DEVICE_ID_INTEL_DH89XXCC_LPC_MAX)) {
> r->name = "PIIX/ICH";
> r->get = pirq_piix_get;
> r->set = pirq_piix_set;
> return 1;
> }
>
> - if ((device >= PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MIN) &&
> - (device <= PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MAX)) {
> - r->name = "PIIX/ICH";
> - r->get = pirq_piix_get;
> - r->set = pirq_piix_set;
> - return 1;
> - }
> return 0;
> }
Applied to linux-next, thanks.
It would be cool if you could figure out a way to avoid having to
continually send these sorts of patches for new chipsets as they come
out. Maybe for stuff newer than a certain date we can just assume PIIX
style interfaces? Or maybe there's a way to refactor this even more
cleanly?
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-02-08 21:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 21:08 [PATCH 2.6.37] lpc: irq and pci_ids patch for Intel DH89xxCC DeviceIDs Seth Heasley
2011-01-10 22:34 ` Jean Delvare
2011-02-08 21:10 ` Jesse Barnes [this message]
2011-03-18 9:26 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110208131015.7345a4df@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=seth.heasley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox