From: Don Zickus <dzickus@redhat.com>
To: Hillf Danton <dhillf@gmail.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: fix setup NMI_LOCAL_APIC watchdog
Date: Tue, 8 Feb 2011 12:38:36 -0500 [thread overview]
Message-ID: <20110208173836.GA27728@redhat.com> (raw)
In-Reply-To: <AANLkTikLveTej7m7UkT6thCxD_nWbEFbF6q=ayGSj2oT@mail.gmail.com>
On Thu, Feb 03, 2011 at 11:07:11PM +0800, Hillf Danton wrote:
> when testing NMI watchdog, at leat for NMI_LOCAL_APIC, the default
> value of nmi_active could prevent the dog from being tested. Even
> could not, lapic_adjust_nmi_hz() could misplay its role since the
> underlying hardware is still not initialized by lapic_watchdog_init().
>
> And for same reason the check for wd_ops could be removed in
> enable_lapic_nmi_watchdog(), in which nmi_active is also checked.
>
> If NMI_LOCAL_APIC is enabled thru sysctl on cmdline after bootup, how
> to test stuckup?
Your patch doesn't apply to 2.6.38 any more because that code has been
removed. We have switched to the new nmi_watchdog. Unless you have other
concerns, I am going to drop your patch.
Cheers,
Don
prev parent reply other threads:[~2011-02-08 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 15:07 [PATCH] x86: fix setup NMI_LOCAL_APIC watchdog Hillf Danton
2011-02-08 17:38 ` Don Zickus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110208173836.GA27728@redhat.com \
--to=dzickus@redhat.com \
--cc=dhillf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).