public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch 0/4] XEN: Interrupt cleanups
Date: Tue, 8 Feb 2011 13:39:37 -0500	[thread overview]
Message-ID: <20110208183937.GD4606@dumpdata.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1102081829330.31804@localhost6.localdomain6>

> > <scratches his head> The rework was in Xen code not in generic, and
> > the only generic changes that are in there ..  are your code?
> 
> The point is:
> 
> If you play with generic irq code in Xen in some weird way then you
> basically block me to cleanup something in the core code w/o breaking
> Xen. I wanted to move IRQ_SUSPENDED to a different field and
> accidentally noticed that Xen was fiddling with in -next.

Aaaaah. I somehow thought the problems were with code proposed for
2.6.39, but you are referring to: "xen: events: do not unmask event channels
on resume" (6903591f314b8947d0e362bda7715e90eb9df75e) which was added way
back in November (post 2.6.37 time-frame) - and is already in Linus tree.

OK, now that I've that clear in my head (sorry about this confusion):
> 
> So that's what I'm grumpy about. You hack away in Xen and claim it's
> confined to your code, while in reality it is _NOT_.

.. I can quite understand why you are unhappy about this.
> 
> Again, if there is a problem with the generic code then talk to me.

Absolutely. We appreciate you being quite dilligient about other
sub-platforms and sorry for this screwup.

> 
> That's going to be impossible anyway when I'm done with the
> encapsulation.

Any thoughts on how to fix that code Xen code for that issue?

> 
> Thanks,
> 
> 	tglx
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

  reply	other threads:[~2011-02-08 18:40 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-05 20:08 [patch 0/4] XEN: Interrupt cleanups Thomas Gleixner
2011-02-05 20:08 ` [patch 1/4] xen: Remove stale irq_chip.end Thomas Gleixner
2011-02-05 20:08 ` [patch 2/4] xen: Switch to new irq_chip functions Thomas Gleixner
2011-02-07 11:08   ` Ian Campbell
2011-02-07 11:30     ` Thomas Gleixner
2011-02-05 20:08 ` [patch 3/4] genirq: Add IRQF_FORCE_RESUME Thomas Gleixner
2011-02-05 20:08 ` [patch 4/4] xen: Use IRQF_FORCE_RESUME Thomas Gleixner
2011-02-07 21:28 ` [patch 0/4] XEN: Interrupt cleanups Jeremy Fitzhardinge
2011-02-07 21:33   ` Thomas Gleixner
2011-02-07 21:57     ` Jeremy Fitzhardinge
2011-02-08 14:03       ` Ian Campbell
2011-02-08 14:55         ` Thomas Gleixner
2011-02-08 15:05           ` Ian Campbell
2011-02-08 15:39             ` Thomas Gleixner
2011-02-08 16:20               ` Konrad Rzeszutek Wilk
2011-02-08 16:31                 ` Ian Campbell
2011-02-08 17:33                 ` Thomas Gleixner
2011-02-08 18:39                   ` Konrad Rzeszutek Wilk [this message]
2011-02-08 19:05                     ` Thomas Gleixner
2011-02-09  9:27                 ` Ian Campbell
2011-02-09  9:46                   ` Thomas Gleixner
2011-02-09  9:48                     ` Thomas Gleixner
2011-02-09 10:16                       ` Ian Campbell
2011-02-09  9:56                     ` Ian Campbell
2011-02-08 16:24               ` Konrad Rzeszutek Wilk
2011-02-08 17:38                 ` Thomas Gleixner
2011-02-08 16:26               ` Ian Campbell
2011-02-07 21:56 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110208183937.GD4606@dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox