Re: [PATCH v2 2/2] man-pages: SYSLOG_ACTION_* constants are now exported

["Serge E. Hallyn" <serge.hallyn@canonical.com>]

Quoting Kees Cook (kees.cook@canonical.com):
> On Tue, Feb 08, 2011 at 11:15:34PM +0100, Paul Bolle wrote:
> > The kernel now exports <linux/syslog.h>. This makes the SYSLOG_ACTION_*
> > constants available to userspace. This allows to replace the magic
> > numbers used in this man page with (what should be) more descriptive
> > names. The quote form kernel/printk.c can now also be dropped.
> > 
> > A few (more or less related) things were also fixed or changed:
> > - add a new sub section "The command types";
> > - the (userspace) buffer is called bufp everywhere (and not buf);
> > - add some whitespace to all call descriptions;
> > - use "ignored" in some call descriptions (instead of "dummy").
> > 
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> 
> Acked-by: Kees Cook <kees.cook@canonical.com>
> 
> 
> As an aside, it might be a good idea to send an additional patch (since
> it's logically separate from this) to update this portion of the man-page:
> 
>    EPERM  An attempt was made to change console_loglevel or clear the
>           kernel message ring buffer by a process without  sufficient
>           privi lege (more precisely: without the CAP_SYS_ADMIN capability).
> 
> At least s/CAP_SYS_ADMIN/CAP_SYSLOG/, but probably include details about
> which options are considered privileged.
> 
> Though that should probably go with including the description of CAP_SYSLOG
> in the "capabilities" man-page.

Thanks for the reminder, Kees.  Michael, I'll try to get an update for
capabilities.7 to you soon.

-serge