From: Willy Tarreau <w@1wt.eu>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Jayson R. King" <dev@jaysonking.com>,
LKML <linux-kernel@vger.kernel.org>,
Stable team <stable@kernel.org>
Subject: Re: [stable] 2.6.27.58-rc1 build error Re: [PATCH 21/23] hvc_console: Fix race between hvc_close and hvc_remove
Date: Wed, 9 Feb 2011 11:34:01 +0100 [thread overview]
Message-ID: <20110209103401.GB18732@1wt.eu> (raw)
In-Reply-To: <20110209094434.3928bf26@lxorguk.ukuu.org.uk>
On Wed, Feb 09, 2011 at 09:44:34AM +0000, Alan Cox wrote:
> On Tue, 08 Feb 2011 21:20:42 -0600
> "Jayson R. King" <dev@jaysonking.com> wrote:
>
> > drivers/char/hvc_console.c: In function 'hvc_open':
> > drivers/char/hvc_console.c:315: error: implicit declaration of function
> > 'tty_kref_get'
> > drivers/char/hvc_console.c:324: warning: assignment makes pointer from
> > integer without a cast
> > drivers/char/hvc_console.c:341: error: implicit declaration of function
> > 'tty_kref_put'
> > drivers/char/hvc_console.c: In function 'hvc_poll':
> > drivers/char/hvc_console.c:558: warning: assignment makes pointer from
> > integer without a cast
> > drivers/char/hvc_console.c: In function 'hvc_remove':
> > drivers/char/hvc_console.c:759: warning: assignment makes pointer from
> > integer without a cast
> >
> > I don't see a tty_kref_get or tty_kref_put on 2.6.27. Those functions
> > first appeared in 2.6.28.
>
> Correct - for 2.6.27 I don't think you *can* make the tty layer
> non-exploitable without a major backport
So unless the bug is critical (I don't think it is), I'd rather avoid
a major backport at this stage.
Willy
prev parent reply other threads:[~2011-02-09 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 3:20 2.6.27.58-rc1 build error Re: [PATCH 21/23] hvc_console: Fix race between hvc_close and hvc_remove Jayson R. King
2011-02-09 5:52 ` [stable] " Willy Tarreau
2011-02-09 9:44 ` Alan Cox
2011-02-09 10:34 ` Willy Tarreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110209103401.GB18732@1wt.eu \
--to=w@1wt.eu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dev@jaysonking.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox