From: Greg KH <greg@kroah.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] Platform: add Samsung Laptop platform driver
Date: Wed, 9 Feb 2011 15:02:59 -0800 [thread overview]
Message-ID: <20110209230259.GA475@kroah.com> (raw)
In-Reply-To: <20110209225056.GA25009@srcf.ucam.org>
On Wed, Feb 09, 2011 at 10:50:56PM +0000, Matthew Garrett wrote:
> \o/
>
> A quick glance suggests that the firmware interface is an abomination
> and really there's no reason for them not to have used an existing
> interface of some sort, but that's par for the course. I'll review it
> properly now.
The firmware interface pre-dates ACPI. Samsung seems to have only
started using ACPI for their newest models, as it's a requirement for
Win7 certification. But even there, they still rely on their SABI
interface for the majority of the "odd" hardware control knobs,
including the backlight control, which baffles me even to this day.
thanks,
greg k-h
next prev parent reply other threads:[~2011-02-09 23:03 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 22:40 [PATCH] Platform: add Samsung Laptop platform driver Greg KH
2011-02-09 22:44 ` Randy Dunlap
2011-02-09 22:50 ` Greg KH
2011-02-09 22:58 ` Matthew Garrett
2011-02-09 22:50 ` Matthew Garrett
2011-02-09 23:02 ` Greg KH [this message]
2011-02-11 11:37 ` Richard Schütz
2011-02-11 15:22 ` Greg KH
2011-02-11 16:27 ` Richard Schütz
2011-02-25 21:01 ` Greg KH
2011-02-11 15:45 ` Matthew Garrett
2011-02-11 18:42 ` Greg KH
2011-02-16 10:06 ` Nikolai Kondrashov
2011-02-25 21:03 ` Greg KH
2011-02-25 21:49 ` Nikolai Kondrashov
2011-02-25 22:50 ` Greg KH
2011-03-10 7:00 ` Nikolai Kondrashov
2011-03-10 17:01 ` Greg KH
2011-03-10 17:13 ` Nikolai Kondrashov
2011-03-10 17:19 ` Greg KH
2011-03-10 17:28 ` Nikolai Kondrashov
2011-03-10 18:09 ` Greg KH
2011-03-10 21:05 ` Nikolai Kondrashov
2011-03-10 21:15 ` Greg KH
2011-03-11 7:12 ` Nikolai Kondrashov
2011-03-11 17:03 ` Greg KH
2011-03-11 19:07 ` Nikolai Kondrashov
2011-03-11 19:34 ` Greg KH
2011-03-11 20:20 ` Nikolai Kondrashov
2011-03-11 20:23 ` Nikolai Kondrashov
2011-03-11 20:35 ` Greg KH
2011-03-11 20:30 ` Greg KH
2011-03-13 10:03 ` Nikolai Kondrashov
2011-03-13 10:55 ` Richard Schütz
2011-03-13 13:02 ` Nikolai Kondrashov
2011-03-13 16:18 ` Greg KH
2011-03-13 17:49 ` Nikolai Kondrashov
2011-03-13 17:58 ` Greg KH
2011-03-13 16:17 ` Greg KH
2011-03-13 16:28 ` Matthew Garrett
2011-03-13 17:51 ` Nikolai Kondrashov
2011-03-13 17:50 ` Nikolai Kondrashov
-- strict thread matches above, loose matches on Subject: below --
2011-02-25 22:47 Greg KH
2011-02-27 15:36 Greg KH
2011-03-05 4:24 Greg KH
2011-03-11 17:43 ` Matthew Garrett
2011-03-11 19:35 ` Greg KH
2011-03-11 19:44 ` Matthew Garrett
2011-03-11 19:52 ` Greg KH
2011-03-11 19:55 ` Matthew Garrett
2011-03-14 15:18 ` Jörg-Volker Peetz
2011-03-11 17:57 Tommaso Massimi
2011-06-26 15:08 J Witteveen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110209230259.GA475@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox