From: Andres Salomon <dilinger@queued.net>
To: gregkh@suse.de
Cc: linux-kernel@vger.kernel.org, cjb@laptop.org,
jon.nettleton@gmail.com, devel@driverdev.osuosl.org
Subject: [PATCH 01/10] olpc_dcon: don't specify single bits for bool fields
Date: Thu, 10 Feb 2011 17:46:07 -0800 [thread overview]
Message-ID: <20110210174607.698e9ae0@queued.net> (raw)
Just use a regular 'bool foo', rather than 'bool foo:1'.
Signed-off-by: Andres Salomon <dilinger@queued.net>
---
drivers/staging/olpc_dcon/olpc_dcon.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
index eec10e7..cc12110 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon.c
@@ -63,8 +63,8 @@ struct dcon_priv {
u8 disp_mode;
/* Current output type; true == mono, false == color */
- bool mono:1;
- bool asleep:1;
+ bool mono;
+ bool asleep;
};
/* I2C structures */
@@ -516,7 +516,7 @@ static ssize_t dcon_sleep_show(struct device *dev,
{
struct dcon_priv *dcon = dev_get_drvdata(dev);
- return sprintf(buf, "%d\n", dcon->asleep ? 1 : 0);
+ return sprintf(buf, "%d\n", dcon->asleep);
}
static ssize_t dcon_freeze_show(struct device *dev,
@@ -529,7 +529,7 @@ static ssize_t dcon_mono_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct dcon_priv *dcon = dev_get_drvdata(dev);
- return sprintf(buf, "%d\n", dcon->mono ? 1 : 0);
+ return sprintf(buf, "%d\n", dcon->mono);
}
static ssize_t dcon_resumeline_show(struct device *dev,
@@ -564,7 +564,7 @@ static ssize_t dcon_mono_store(struct device *dev,
if (_strtoul(buf, count, &enable_mono))
return -EINVAL;
- dcon_set_mono_mode(dev_get_drvdata(dev), enable_mono ? 1 : 0);
+ dcon_set_mono_mode(dev_get_drvdata(dev), enable_mono ? true : false);
rc = count;
return rc;
--
1.7.2.3
reply other threads:[~2011-02-11 1:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110210174607.698e9ae0@queued.net \
--to=dilinger@queued.net \
--cc=cjb@laptop.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jon.nettleton@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox