From: Greg KH <gregkh@suse.de>
To: Oren Weil <oren.jer.weil@intel.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
david@woodhou.se, david.woodhouse@intel.com
Subject: Re: [RFC PATCH 01/13] Intel(R) MEI Driver
Date: Thu, 10 Feb 2011 10:00:44 -0800 [thread overview]
Message-ID: <20110210180044.GD13795@suse.de> (raw)
In-Reply-To: <b9dded$htd8nk@orsmga002.jf.intel.com>
On Thu, Feb 10, 2011 at 01:54:57AM -0800, Oren Weil wrote:
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
Where is the description?
Where is the signed-off-by line?
> index b7980a8..0a54b26 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -1144,5 +1144,16 @@ config RAMOOPS
> This enables panic and oops messages to be logged to a circular
> buffer in RAM where it can be read back at some later point.
>
> +config INTEL_MEI
> + tristate "Intel(R) Management Engine Interface (Intel(R) MEI)"
What's with the (R) symbols everywhere? The Linux kernel is not a place
for this.
> + default m
No, this is not a valid default.
> + depends on EXPERIMENTAL && X86
> + help
> + If you have an Intel(R) ME chip in your system
Trailing whitespace, which shows that you didn't take the simple time to
run your patches through scripts/checkpatch.pl, so why should we take
time to review them?
And you don't add a config option as your first patch, it does nothing
at this point in time for any code that is existing in the kernel.
greg k-h
next prev parent reply other threads:[~2011-02-10 18:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 9:54 [RFC PATCH 01/13] Intel(R) MEI Driver Oren Weil
2011-02-10 16:50 ` Randy Dunlap
2011-02-10 18:00 ` Greg KH [this message]
2011-02-11 8:57 ` Weil, Oren jer
2011-02-11 9:19 ` David Woodhouse
2011-02-11 14:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110210180044.GD13795@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david.woodhouse@intel.com \
--cc=david@woodhou.se \
--cc=linux-kernel@vger.kernel.org \
--cc=oren.jer.weil@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox