* [RFC PATCH 01/13] Intel(R) MEI Driver @ 2011-02-10 9:54 Oren Weil 2011-02-10 16:50 ` Randy Dunlap 2011-02-10 18:00 ` Greg KH 0 siblings, 2 replies; 6+ messages in thread From: Oren Weil @ 2011-02-10 9:54 UTC (permalink / raw) To: gregkh, akpm, linux-kernel; +Cc: david, david.woodhouse diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig index b7980a8..0a54b26 100644 --- a/drivers/char/Kconfig +++ b/drivers/char/Kconfig @@ -1144,5 +1144,16 @@ config RAMOOPS This enables panic and oops messages to be logged to a circular buffer in RAM where it can be read back at some later point. +config INTEL_MEI + tristate "Intel(R) Management Engine Interface (Intel(R) MEI)" + default m + depends on EXPERIMENTAL && X86 + help + If you have an Intel(R) ME chip in your system + say Yes to enable the Intel(R) Managment Engine interface. + for more informaiton see + <http://software.intel.com/en-us/manageability/> + + endmenu --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 01/13] Intel(R) MEI Driver 2011-02-10 9:54 [RFC PATCH 01/13] Intel(R) MEI Driver Oren Weil @ 2011-02-10 16:50 ` Randy Dunlap 2011-02-10 18:00 ` Greg KH 1 sibling, 0 replies; 6+ messages in thread From: Randy Dunlap @ 2011-02-10 16:50 UTC (permalink / raw) To: Oren Weil; +Cc: gregkh, akpm, linux-kernel, david, david.woodhouse On 10 Feb 2011 01:54:57 -0800 Oren Weil wrote: > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig > index b7980a8..0a54b26 100644 > --- a/drivers/char/Kconfig > +++ b/drivers/char/Kconfig > @@ -1144,5 +1144,16 @@ config RAMOOPS > This enables panic and oops messages to be logged to a circular > buffer in RAM where it can be read back at some later point. > > +config INTEL_MEI > + tristate "Intel(R) Management Engine Interface (Intel(R) MEI)" > + default m Please don't enable random kconfig options. > + depends on EXPERIMENTAL && X86 > + help > + If you have an Intel(R) ME chip in your system > + say Yes to enable the Intel(R) Managment Engine interface. > + for more informaiton see > + <http://software.intel.com/en-us/manageability/> > + > + > endmenu --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 01/13] Intel(R) MEI Driver 2011-02-10 9:54 [RFC PATCH 01/13] Intel(R) MEI Driver Oren Weil 2011-02-10 16:50 ` Randy Dunlap @ 2011-02-10 18:00 ` Greg KH 2011-02-11 8:57 ` Weil, Oren jer 1 sibling, 1 reply; 6+ messages in thread From: Greg KH @ 2011-02-10 18:00 UTC (permalink / raw) To: Oren Weil; +Cc: akpm, linux-kernel, david, david.woodhouse On Thu, Feb 10, 2011 at 01:54:57AM -0800, Oren Weil wrote: > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig Where is the description? Where is the signed-off-by line? > index b7980a8..0a54b26 100644 > --- a/drivers/char/Kconfig > +++ b/drivers/char/Kconfig > @@ -1144,5 +1144,16 @@ config RAMOOPS > This enables panic and oops messages to be logged to a circular > buffer in RAM where it can be read back at some later point. > > +config INTEL_MEI > + tristate "Intel(R) Management Engine Interface (Intel(R) MEI)" What's with the (R) symbols everywhere? The Linux kernel is not a place for this. > + default m No, this is not a valid default. > + depends on EXPERIMENTAL && X86 > + help > + If you have an Intel(R) ME chip in your system Trailing whitespace, which shows that you didn't take the simple time to run your patches through scripts/checkpatch.pl, so why should we take time to review them? And you don't add a config option as your first patch, it does nothing at this point in time for any code that is existing in the kernel. greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [RFC PATCH 01/13] Intel(R) MEI Driver 2011-02-10 18:00 ` Greg KH @ 2011-02-11 8:57 ` Weil, Oren jer 2011-02-11 9:19 ` David Woodhouse 2011-02-11 14:53 ` Greg KH 0 siblings, 2 replies; 6+ messages in thread From: Weil, Oren jer @ 2011-02-11 8:57 UTC (permalink / raw) To: Greg KH Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, david@woodhou.se, Woodhouse, David [-- Attachment #1.1: Type: text/plain, Size: 1813 bytes --] Hi 1) For the review purpose we wanted to split the patches into files, so the only way we found to do it is using "git diff", this is they there is not signed-off-by line Maybe I should have adding a description for every file, I can send another mail with the descriptions, sorry for the mess. 2) "Intel(R) Management Engine Interface (Intel(R) MEI)" - is our official name. 3) we ran checkpatch.pl on every file, this file my by skipped by mistake. -----Original Message----- From: Greg KH [mailto:gregkh@suse.de] Sent: Thursday, February 10, 2011 20:01 To: Weil, Oren jer Cc: akpm@linux-foundation.org; linux-kernel@vger.kernel.org; david@woodhou.se; Woodhouse, David Subject: Re: [RFC PATCH 01/13] Intel(R) MEI Driver On Thu, Feb 10, 2011 at 01:54:57AM -0800, Oren Weil wrote: > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig Where is the description? Where is the signed-off-by line? > index b7980a8..0a54b26 100644 > --- a/drivers/char/Kconfig > +++ b/drivers/char/Kconfig > @@ -1144,5 +1144,16 @@ config RAMOOPS > This enables panic and oops messages to be logged to a circular > buffer in RAM where it can be read back at some later point. > > +config INTEL_MEI > + tristate "Intel(R) Management Engine Interface (Intel(R) MEI)" What's with the (R) symbols everywhere? The Linux kernel is not a place for this. > + default m No, this is not a valid default. > + depends on EXPERIMENTAL && X86 > + help > + If you have an Intel(R) ME chip in your system Trailing whitespace, which shows that you didn't take the simple time to run your patches through scripts/checkpatch.pl, so why should we take time to review them? And you don't add a config option as your first patch, it does nothing at this point in time for any code that is existing in the kernel. greg k-h [-- Attachment #1.2: smime.p7s --] [-- Type: application/pkcs7-signature, Size: 8587 bytes --] [-- Attachment #2: Type: text/plain, Size: 366 bytes --] --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [RFC PATCH 01/13] Intel(R) MEI Driver 2011-02-11 8:57 ` Weil, Oren jer @ 2011-02-11 9:19 ` David Woodhouse 2011-02-11 14:53 ` Greg KH 1 sibling, 0 replies; 6+ messages in thread From: David Woodhouse @ 2011-02-11 9:19 UTC (permalink / raw) To: Weil, Oren jer Cc: Greg KH, akpm@linux-foundation.org, linux-kernel@vger.kernel.org On Fri, 2011-02-11 at 10:57 +0200, Weil, Oren jer wrote: > > 1) For the review purpose we wanted to split the patches into files, so the > only way we found to do it is using "git diff", this is they there is not > signed-off-by line So you type it manually, when you're setting an appropriate subject and typing your coherent explanation of what's in each patch, and how it fits together. -- dwmw2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 01/13] Intel(R) MEI Driver 2011-02-11 8:57 ` Weil, Oren jer 2011-02-11 9:19 ` David Woodhouse @ 2011-02-11 14:53 ` Greg KH 1 sibling, 0 replies; 6+ messages in thread From: Greg KH @ 2011-02-11 14:53 UTC (permalink / raw) To: Weil, Oren jer Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, david@woodhou.se, Woodhouse, David On Fri, Feb 11, 2011 at 10:57:31AM +0200, Weil, Oren jer wrote: > Hi > > 1) For the review purpose we wanted to split the patches into files, so the > only way we found to do it is using "git diff", this is they there is not > signed-off-by line > Maybe I should have adding a description for every file, I can send another > mail with the descriptions, sorry for the mess. Again, please read the documentation on how to properly send patches. We write it for a reason, not to just be ignored. Actually, if you do ignore it, it's easy for us to ignore you, and somehow I doubt you want that. > 2) "Intel(R) Management Engine Interface (Intel(R) MEI)" - is our official > name. That's nice, but it's not anything that kernel developers want to see all the time. Drop the (R) please, it's pointless within the kernel sources. > 3) we ran checkpatch.pl on every file, this file my by skipped by mistake. It wasn't the only file you skipped, I saw lots of coding style violations in the other files, so I really don't believe you. good luck, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-02-11 14:52 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-02-10 9:54 [RFC PATCH 01/13] Intel(R) MEI Driver Oren Weil 2011-02-10 16:50 ` Randy Dunlap 2011-02-10 18:00 ` Greg KH 2011-02-11 8:57 ` Weil, Oren jer 2011-02-11 9:19 ` David Woodhouse 2011-02-11 14:53 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox