From: Greg KH <gregkh@suse.de>
To: Oren Weil <oren.jer.weil@intel.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
david@woodhou.se, david.woodhouse@intel.com
Subject: Re: [RFC PATCH 02/13] Intel(R) MEI Driver
Date: Thu, 10 Feb 2011 10:01:45 -0800 [thread overview]
Message-ID: <20110210180145.GE13795@suse.de> (raw)
In-Reply-To: <849307$bgs43u@azsmga001.ch.intel.com>
On Thu, Feb 10, 2011 at 01:55:00AM -0800, Oren Weil wrote:
> diff --git a/drivers/char/Makefile b/drivers/char/Makefile
No description, or signed-off-by lines. Have you read how to properly
create and submit a patch? If so, why did you ignore those rules?
> index 5bc765d..e43ea27 100644
> --- a/drivers/char/Makefile
> +++ b/drivers/char/Makefile
> @@ -84,4 +84,5 @@ obj-$(CONFIG_PS3_FLASH) += ps3flash.o
> obj-$(CONFIG_RAMOOPS) += ramoops.o
>
> obj-$(CONFIG_JS_RTC) += js-rtc.o
> +obj-$(CONFIG_INTEL_MEI) += mei/
You just broke the build.
I'm not going to review farther, it's a waste of my, and every one
else's time.
greg k-h
prev parent reply other threads:[~2011-02-10 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 9:55 [RFC PATCH 02/13] Intel(R) MEI Driver Oren Weil
2011-02-10 18:01 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110210180145.GE13795@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david.woodhouse@intel.com \
--cc=david@woodhou.se \
--cc=linux-kernel@vger.kernel.org \
--cc=oren.jer.weil@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox