From: Greg KH <gregkh@suse.de>
To: "Weil, Oren jer" <oren.jer.weil@intel.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"david@woodhou.se" <david@woodhou.se>,
"Woodhouse, David" <david.woodhouse@intel.com>
Subject: Re: [RFC PATCH 01/13] Intel(R) MEI Driver
Date: Fri, 11 Feb 2011 06:53:16 -0800 [thread overview]
Message-ID: <20110211145316.GA13146@suse.de> (raw)
In-Reply-To: <F28B59AD52D84B479DCA46982447533506505D9ACE@hasmsx503.ger.corp.intel.com>
On Fri, Feb 11, 2011 at 10:57:31AM +0200, Weil, Oren jer wrote:
> Hi
>
> 1) For the review purpose we wanted to split the patches into files, so the
> only way we found to do it is using "git diff", this is they there is not
> signed-off-by line
> Maybe I should have adding a description for every file, I can send another
> mail with the descriptions, sorry for the mess.
Again, please read the documentation on how to properly send patches.
We write it for a reason, not to just be ignored.
Actually, if you do ignore it, it's easy for us to ignore you, and
somehow I doubt you want that.
> 2) "Intel(R) Management Engine Interface (Intel(R) MEI)" - is our official
> name.
That's nice, but it's not anything that kernel developers want to see
all the time. Drop the (R) please, it's pointless within the kernel
sources.
> 3) we ran checkpatch.pl on every file, this file my by skipped by mistake.
It wasn't the only file you skipped, I saw lots of coding style
violations in the other files, so I really don't believe you.
good luck,
greg k-h
prev parent reply other threads:[~2011-02-11 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 9:54 [RFC PATCH 01/13] Intel(R) MEI Driver Oren Weil
2011-02-10 16:50 ` Randy Dunlap
2011-02-10 18:00 ` Greg KH
2011-02-11 8:57 ` Weil, Oren jer
2011-02-11 9:19 ` David Woodhouse
2011-02-11 14:53 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110211145316.GA13146@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david.woodhouse@intel.com \
--cc=david@woodhou.se \
--cc=linux-kernel@vger.kernel.org \
--cc=oren.jer.weil@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox