RE: [RFC PATCH 01/13] Intel(R) MEI Driver

Weil, Oren jer
2011-02-11T08:58:47Z

[-- Attachment #1.1: Type: text/plain, Size: 1813 bytes --]

Hi

1) For the review purpose we wanted to split the patches into files, so the
only way we found to do it is using "git diff", this is they there is not
signed-off-by line
Maybe I should have adding a description for every file, I can send another
mail with the descriptions, sorry for the mess.

2) "Intel(R) Management Engine Interface (Intel(R) MEI)" - is our official
name.

3) we ran checkpatch.pl on every file, this file my by skipped by mistake.

-----Original Message-----
From: Greg KH [mailto:gregkh@suse.de]
Sent: Thursday, February 10, 2011 20:01
To: Weil, Oren jer
Cc: akpm@linux-foundation.org; linux-kernel@vger.kernel.org;
david@woodhou.se; Woodhouse, David
Subject: Re: [RFC PATCH 01/13] Intel(R) MEI Driver

On Thu, Feb 10, 2011 at 01:54:57AM -0800, Oren Weil wrote:
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig

Where is the description?

Where is the signed-off-by line?

> index b7980a8..0a54b26 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -1144,5 +1144,16 @@ config RAMOOPS
> This enables panic and oops messages to be logged to a circular
> buffer in RAM where it can be read back at some later point.
>
> +config INTEL_MEI
> + tristate "Intel(R) Management Engine Interface (Intel(R) MEI)"

What's with the (R) symbols everywhere? The Linux kernel is not a place for
this.

> + default m

No, this is not a valid default.

> + depends on EXPERIMENTAL && X86
> + help
> + If you have an Intel(R) ME chip in your system

Trailing whitespace, which shows that you didn't take the simple time to run
your patches through scripts/checkpatch.pl, so why should we take time to
review them?

And you don't add a config option as your first patch, it does nothing at
this point in time for any code that is existing in the kernel.

greg k-h

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 8587 bytes --]

[-- Attachment #2: Type: text/plain, Size: 366 bytes --]

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.