Re: [RFC PATCH 01/13] Intel(R) MEI Driver

Greg KH
2011-02-10T18:02:05Z

On Thu, Feb 10, 2011 at 01:54:57AM -0800, Oren Weil wrote:
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig

Where is the description?

Where is the signed-off-by line?

> index b7980a8..0a54b26 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -1144,5 +1144,16 @@ config RAMOOPS
> This enables panic and oops messages to be logged to a circular
> buffer in RAM where it can be read back at some later point.
>
> +config INTEL_MEI
> + tristate "Intel(R) Management Engine Interface (Intel(R) MEI)"

What's with the (R) symbols everywhere? The Linux kernel is not a place
for this.

> + default m

No, this is not a valid default.

> + depends on EXPERIMENTAL && X86
> + help
> + If you have an Intel(R) ME chip in your system

Trailing whitespace, which shows that you didn't take the simple time to
run your patches through scripts/checkpatch.pl, so why should we take
time to review them?

And you don't add a config option as your first patch, it does nothing
at this point in time for any code that is existing in the kernel.

greg k-h