Re: [RFC PATCH 01/13] Intel(R) MEI Driver

Greg KH
2011-02-11T14:52:39Z

On Fri, Feb 11, 2011 at 10:57:31AM +0200, Weil, Oren jer wrote:
> Hi
>
> 1) For the review purpose we wanted to split the patches into files, so the
> only way we found to do it is using "git diff", this is they there is not
> signed-off-by line
> Maybe I should have adding a description for every file, I can send another
> mail with the descriptions, sorry for the mess.

Again, please read the documentation on how to properly send patches.
We write it for a reason, not to just be ignored.

Actually, if you do ignore it, it's easy for us to ignore you, and
somehow I doubt you want that.

> 2) "Intel(R) Management Engine Interface (Intel(R) MEI)" - is our official
> name.

That's nice, but it's not anything that kernel developers want to see
all the time. Drop the (R) please, it's pointless within the kernel
sources.

> 3) we ran checkpatch.pl on every file, this file my by skipped by mistake.

It wasn't the only file you skipped, I saw lots of coding style
violations in the other files, so I really don't believe you.

good luck,

greg k-h