From: Greg KH <gregkh@suse.de>
To: yenchengwang <yenchengwang@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
dbrownell@users.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: f_mass_storage: fixed a macro coding style issue
Date: Sat, 12 Feb 2011 08:04:04 -0800 [thread overview]
Message-ID: <20110212160404.GD26211@suse.de> (raw)
In-Reply-To: <AANLkTim_ZiR_GuD3e6KixxtX+r9z0+y2D66VJBRpp1ab@mail.gmail.com>
On Sat, Feb 12, 2011 at 04:15:21PM +0800, yenchengwang wrote:
> ah, I think I made a mistake...
> I watched this video
> http://archive.fosdem.org/2010/schedule/events/linuxkernelpatch,
> then tried the ./scripts/checkpatch.pl and see two ERROR:...
> so ... sent this patch, I apologize for my mistake, :(
That's great to do that, but you forgot the part of that talk that
showed you had to build your patch to verify that you did not break
anything. Please do that in the future.
thanks,
greg k-h
prev parent reply other threads:[~2011-02-12 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 15:36 [PATCH] usb: gadget: f_mass_storage: fixed a macro coding style issue ycwang
2011-02-11 17:39 ` Greg KH
2011-02-11 18:57 ` Dmitry Torokhov
2011-02-11 19:13 ` Greg KH
[not found] ` <AANLkTim_ZiR_GuD3e6KixxtX+r9z0+y2D66VJBRpp1ab@mail.gmail.com>
2011-02-12 16:04 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110212160404.GD26211@suse.de \
--to=gregkh@suse.de \
--cc=dbrownell@users.sourceforge.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yenchengwang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox