From: Ingo Molnar <mingo@elte.hu>
To: Henrik Kretzschmar <henne@nachtwindheim.de>
Cc: mingo@readhat.com, tglx@linutronix.de, hpa@zytor.com,
x86@kernel.org, tj@kernel.org, yinghai@kernel.org,
ak@linux.intel.com, robert.richter@amd.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] x86: move ioapic_irq_destination_types
Date: Mon, 14 Feb 2011 12:05:28 +0100 [thread overview]
Message-ID: <20110214110528.GD7140@elte.hu> (raw)
In-Reply-To: <1297677612-12405-1-git-send-email-henne@nachtwindheim.de>
* Henrik Kretzschmar <henne@nachtwindheim.de> wrote:
> +++ b/arch/x86/include/asm/apicdef.h
> @@ -426,4 +426,16 @@ struct local_apic {
> #else
> #define BAD_APICID 0xFFFFu
> #endif
> +
> +enum ioapic_irq_destination_types {
> + dest_Fixed = 0,
> + dest_LowestPrio = 1,
> + dest_SMI = 2,
> + dest__reserved_1 = 3,
> + dest_NMI = 4,
> + dest_INIT = 5,
> + dest__reserved_2 = 6,
> + dest_ExtINT = 7
> +};
one very small request, while we are moving it could you please align the value
enumeration vertically? Something like:
enum ioapic_irq_destination_types {
dest_Fixed = 0,
dest_LowestPrio = 1,
dest_SMI = 2,
dest__reserved_1 = 3,
dest_NMI = 4,
dest_INIT = 5,
dest__reserved_2 = 6,
dest_ExtINT = 7
};
... would be much more readable, right?
Thanks,
Ingo
prev parent reply other threads:[~2011-02-14 11:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 10:00 [PATCH 1/6] x86: move ioapic_irq_destination_types Henrik Kretzschmar
2011-02-14 10:00 ` [PATCH 2/6] x86: ifdef enable_IR_x2apic() out Henrik Kretzschmar
2011-02-14 11:03 ` Ingo Molnar
2011-02-15 13:47 ` Henrik Kretzschmar
2011-02-15 14:13 ` Gleb Natapov
2011-02-14 10:00 ` [PATCH 3/6] x86: ifdef INTR_REMAP code out Henrik Kretzschmar
2011-02-14 11:02 ` Ingo Molnar
2011-02-14 10:00 ` [PATCH 4/6] x86: add dummy mp_save_irq() Henrik Kretzschmar
2011-02-14 10:00 ` [PATCH 5/6] x86: ifdef ioapic related function out Henrik Kretzschmar
2011-02-14 11:00 ` Ingo Molnar
2011-02-14 10:00 ` [PATCH 6/6] x86: makes X86_UP_IOAPIC work again Henrik Kretzschmar
2011-02-14 11:05 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110214110528.GD7140@elte.hu \
--to=mingo@elte.hu \
--cc=ak@linux.intel.com \
--cc=henne@nachtwindheim.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@readhat.com \
--cc=robert.richter@amd.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox